Closed (fixed)
Project:
Drupal core
Version:
10.1.x-dev
Component:
Claro theme
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Jan 2023 at 17:23 UTC
Updated:
28 Apr 2023 at 21:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gauravvvv commentedComment #4
gauravvvv commentedComment #5
smustgrave commentedSeems to have two instances of
width: 240px;
width: 15rem;
Which one should it be?
Also 8 instances of [dir="rtl"] should those be replaced?
Since the .css file changed this will need before/after screenshots too
Comment #6
gauravvvv commentedI have removed the duplicate width property. Also rtl styling is also refactored. please review
Before patch

After patch

Comment #7
smustgrave commentedThanks!
Comment #8
nod_Appart from the selector change, patch looks good.
The selector change makes the tour button show up on pages where there are no tour for example.
Comment #9
gauravvvv commentedUpdated the selector.
Comment #10
santosh_verma commentedTested the MR #3425
1. Nesting added
2. Normal css replaced with Logical Properties
3. Addressed the comment #9, Selector change reverted in the commit 3
Tested UI manually Nothing looks like broken

RTBC +1
Comment #11
smustgrave commentedOpen thread has been addressed.
Comment #13
nod_Committed 3d86f4c and pushed to 10.1.x. Thanks!