Closed (fixed)
Project:
Drupal core
Version:
10.1.x-dev
Component:
Claro theme
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2023 at 23:00 UTC
Updated:
28 Apr 2023 at 07:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bspeare commentedComment #5
gauravvvv commentedThere should be no visual differences. here is the before and after patch screenshot. Please review
Before patch:
After patch:
Comment #6
smustgrave commentedhaha like you knew I was going to ask for screenshots!
Everything looks good.
Nesting seems correct and I don't see any hardcoded values
Comment #7
lauriiiPosted some feedback on the MR. Thank you for working on these issues! 😊
Comment #8
gauravvvv commentedComment #9
smustgrave commentedAppears the changes requested have been implemented.
Comment #10
lauriiiThere are some styles RTL styles that are depending on #3332461: Refactor Claro's system-admin--status-report stylesheet. I'm wondering if we should merge these two issues so that we can make sure everything works as expected?
Comment #11
smustgrave commentedClosed #3332461: Refactor Claro's system-admin--status-report stylesheet so work there should be combined here. Didn't need to move credit as they are already here.
Comment #12
gauravvvv commentedMerged
system-admin--status-report.cssandsystem-status-report.cssPlease reviewAfter patch

Comment #13
smustgrave commentedThanks for the quick turnaround!
Comment #14
nod_need rebasing
Comment #16
rassoni commentedRebase the branch. Please review.
Comment #17
smustgrave commentedRebase look good.
Comment #19
nod_Patch fixes some layout issues in RTL, nice.
Committed 2f8c703 and pushed to 10.1.x. Thanks!