Closed (works as designed)
Project:
Drupal core
Version:
10.1.x-dev
Component:
Claro theme
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Jan 2023 at 20:27 UTC
Updated:
22 Feb 2023 at 14:43 UTC
Jump to comment: Most recent
Comments
Comment #2
bspeare commentedComment #6
royalpinto007This change ensures that the margin of the node__submitted class only affects the top margin, which can improve consistency and readability. By using margin-top instead of margin, we can also reduce the potential for unintended side effects or conflicting styles that may arise from using the shorthand margin property.
Comment #7
hot_sauce commented@royalpinto007
Switching to
margin-topnegates the bottom margin being set, which is needed, and also sets an inherited margin for the side margins, which may be need to be set as 0.We could refactor this to use:
But that is the same as what this file has currently of
margin: 1em 0I think the shorthand for this file is fine and there may not be any actual changes needed here.
Comment #8
gauravvvv commentedI agree with @hotsaucedesign here. This file doesn't need any modifications. It's already using shorthand property.
Comment #9
hot_sauce commentedThank you @Gauravvv, will mark this one as Closed (works as designed)