This module is still using old README.md template format in README.md file.

Follow the pattern in the README.md template.

Issue fork mailchimp-3332151

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shubham Rathore created an issue. See original summary.

Shubham Rathore opened merge request !31

shubham rathore’s picture

shubham rathore commented
Assigned: shubham rathore » Unassigned
Status: Active » Needs review

Create MR for README.md file update.
Please review.
Thanks.

nupur badola’s picture

nupur badola commented

Reviewed MR!31, Getting error while applying the patch.

1. error: patch failed: README.md:1
error: README.md: patch does not apply
2. #/## is missing for the heading.
3. Title of the section should be "Table of content" not "CONTENTS OF THIS FILE".
4. Name of the project is missing.
5. * is used in place of -
6. Complete file is not as per the format of readme.md file.
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

gajanan.wasnik made their first commit to this issue’s fork.

gajanan.wasnik opened merge request !76

gajanan.wasnik’s picture

gajanan.wasnik commented
Assigned: Unassigned » gajanan.wasnik
Status: Needs work » Needs review
gajanan.wasnik’s picture

gajanan.wasnik commented
Status: Needs review » Needs work

gajanan.wasnik opened merge request !77

gajanan.wasnik’s picture

gajanan.wasnik commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!77, the file does not follow readme.md file template.

1. 77.diff.txt:220: trailing whitespace.
     Mailchimp suggests keeping this below 10000.
warning: 1 line adds whitespace errors.
gajanan.wasnik’s picture

gajanan.wasnik commented
Status: Needs work » Needs review
nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR!77, the file is updated as per the readme.md file template.
Hence marking it to RTBC.

xenophyle made their first commit to this issue’s fork.

xenophyle’s picture

xenophyle commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.