[8.x-1.x] Visualization Charts

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

@vishal.kadam
It seems you have missed working on the coding standards. You can use PHPCS tool for checking and resolving issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml visualization_charts

FILE: /var/www/html/visualization_charts/assets/slickgrid/slick.grid.min.css
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------


FILE: /var/www/html/visualization_charts/assets/nvd3/nv.d3.min.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------


FILE: /var/www/html/visualization_charts/assets/chosen/chosen.min.css
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------


FILE: /var/www/html/visualization_charts/assets/reclineViewNvd3/style.min.css
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------
 1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------


FILE: /var/www/html/visualization_charts/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------
 1 | WARNING | [ ] Line exceeds 80 characters; contains 224 characters
 4 | WARNING | [ ] Line exceeds 80 characters; contains 196 characters
 4 | ERROR   | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: /var/www/html/visualization_charts/visualization_charts.module
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
 36 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: /var/www/html/visualization_charts/css/visualization-chart.css
------------------------------------------------------------------------------------------------
FOUND 32 ERRORS AFFECTING 30 LINES
------------------------------------------------------------------------------------------------
  55 | ERROR | [x] CSS colours must be defined in lowercase; expected #52a5a0 but found #52A5A0
  56 | ERROR | [x] CSS colours must be defined in lowercase; expected #52a5a0 but found #52A5A0
  78 | ERROR | [x] Multiple selectors should each be on a single line
  88 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 105 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 168 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 174 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 189 | ERROR | [x] Multiple selectors should each be on a single line
 200 | ERROR | [ ] Style definitions must end with a semicolon
 275 | ERROR | [x] CSS colours must be defined in lowercase; expected #dddddd but found #DDDDDD
 293 | ERROR | [ ] Class definition is empty
 299 | ERROR | [x] Opening brace should be the last content on the line
 299 | ERROR | [x] Closing brace of class definition must be on new line
 322 | ERROR | [x] Multiple selectors should each be on a single line
 495 | ERROR | [ ] More than 2 empty lines are not allowed
 496 | ERROR | [ ] More than 2 empty lines are not allowed
 528 | ERROR | [ ] Class definition is empty
 546 | ERROR | [x] Multiple selectors should each be on a single line
 546 | ERROR | [x] Multiple selectors should each be on a single line
 550 | ERROR | [x] CSS colours must be defined in lowercase; expected #3b3b3b but found #3B3B3B
 554 | ERROR | [x] Multiple selectors should each be on a single line
 555 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 556 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 560 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 561 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 562 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 563 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 588 | ERROR | [x] Multiple selectors should each be on a single line
 621 | ERROR | [x] Multiple selectors should each be on a single line
 622 | ERROR | [x] Multiple selectors should each be on a single line
 627 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 631 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Time: 231ms; Memory: 12MB

I will work on this issue.

Hello @irfan.gul,

This application is open, only the user who opened the application can make commits to the project used for the application.

No patches need to be provided.

Hello
@vishal.kadam,
8.x-1.0 there is no such branch in the repo. Tag name isn't the branch name.

Thanks

1. 8.x-1.1 this is wrong, but rest two branches are fine. For Info: https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintainers/release-naming-conventions#release-branches
2. update README file according to https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template

Thanks

Rest seems fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thanks

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go to all the reviewers.