Problem/Motivation

Drupal 10.0.0 stable was released on: 15 Dec 2022 by the Drupal core team
https://www.drupal.org/project/drupal/releases/10.0.0


Thank you so much!

#3279534: Start a 2.0.x branch to support Drupal 10 and update all use of deprecation in the Ace Code Editor module

Proposed resolution

Release an alpha release tag ( 2.0.0-alpha1 ) for extra testing with Drupal 10

Remaining tasks

  • Have a full real physical testing round with Drupal ~10 and Drupal ~9

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Category: Feature request » Task
Status: Active » Needs review
rajab natshah’s picture

Priority: Normal » Major

Thank you, Gonzalo for having time to maintain this needed module.
Hoping for a tag release. To speed up further adaption to use under Drupal 10.
Tested the 2.0.x-dev development branch before.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Had Real physical testing round for Ace Code Editor with Drupal ~10

Build Drupal ~10.0 sandbox test site and have Drush ~11.0

composer create-project drupal/recommended-project:~10.0 /var/www/html/sandboxes/drupal10ace_editor__test
cd /var/www/html/sandboxes/drupal10ace_editor__test/
composer require drush/drush:~11.0;

Add assets repository

composer config repositories.assets composer https://asset-packagist.org
composer config --json extra.installer-types '["npm-asset", "bower-asset"]'
composer config --json extra.installer-paths.web\/libraries\/ace '["npm-asset/ace-builds"]'
composer config --unset extra.installer-paths.web\/libraries\/\{\$name\}
composer config --json extra.installer-paths.web\/libraries\/\{\$name\} '["type:drupal-library", "type:bower-asset", "type:npm-asset"]'

Add the ACE Code Editor module

composer require drupal/ace_editor:2.0.x-dev;

Change file/directory mod and ownership of files:

cd /var/www/html/sandboxes/drupal10ace_editor__test/
sudo chmod 775 -R .;sudo chown www-data:$USER -R .;

Install with Drush

./vendor/drush/drush/drush site:install standard --yes --site-name="Ace Code Editor - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10ace_editor__test" -vvv ;

./vendor/drush/drush/drush pm:enable ace_editor
[success] Successfully enabled: ace_editor

Rebuild the cache:

sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
./vendor/drush/drush/drush cache:rebuild

Open a browser and change the address to:
http://localhost/sandboxes/drupal10ace_editor__test/web/

Configure the Restricted HTML text format to use the ACE Editor

For sure Site admins needs to un-check the "Limit allowed HTML tags and correct faulty HTML" checkbox which is not recommended. Or follow up with the "Allowed HTML tags" to have only the needed allowed tags.

Text formats and editors

Restricted HTML text format is using the ACE Editor

Have a test Basic page with CKEditor 5
Have a test Basic page with CKEditor 5

The Basic page after saving with CKEditor 5
The Basic page after saving with CKEditor 5

Edit the same test page but switch the text format to use the Restricted HTML with ACE Code Editor.
Restricted HTML with ACE Code Editor

For sure Site admins needs to un-check the "Limit allowed HTML tags and correct faulty HTML" checkbox which is not recommended. Or follow up with the "Allowed HTML tags" to have only the needed allowed tags.

rajab natshah’s picture

Had Real physical testing round for Ace Code Editor with Drupal ~9.0 too

Build Drupal ~9.0 sandbox test site and have Drush ~11.0

composer create-project drupal/recommended-project:~9.0 /var/www/html/sandboxes/drupal9ace_editor__test
cd /var/www/html/sandboxes/drupal9ace_editor__test/
composer require drush/drush:~11.0;

Change minimum stability to dev for testing on the recommended Drupal 9 project template

composer config minimum-stability dev

Add assets repository

composer config repositories.assets composer https://asset-packagist.org
composer config --json extra.installer-types '["npm-asset", "bower-asset"]'
composer config --json extra.installer-paths.web\/libraries\/ace '["npm-asset/ace-builds"]'
composer config --unset extra.installer-paths.web\/libraries\/\{\$name\}
composer config --json extra.installer-paths.web\/libraries\/\{\$name\} '["type:drupal-library", "type:bower-asset", "type:npm-asset"]'

Add the ACE Code Editor module

composer require drupal/ace_editor:2.0.x-dev;

Change file/directory mod and ownership of files:

cd /var/www/html/sandboxes/drupal9ace_editor__test/
sudo chmod 775 -R .;sudo chown www-data:$USER -R .;

Install with Drush

./vendor/drush/drush/drush site:install standard --yes --site-name="Ace Code Editor - Real physical testing with Drupal ~9" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal9ace_editor__test" -vvv ;

./vendor/drush/drush/drush pm:enable ace_editor
[success] Successfully enabled: ace_editor

Rebuild the cache:

sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
./vendor/drush/drush/drush cache:rebuild

Open a browser and change the address to:
http://localhost/sandboxes/drupal9ace_editor__test/web/

Configure the Restricted HTML text format to use the ACE Editor

For sure Site admins needs to un-check the "Limit allowed HTML tags and correct faulty HTML" checkbox which is not recommended. Or follow up with the "Allowed HTML tags" to have only the needed allowed tags.

Have a test Basic page with CKEditor 5
test Basic page with CKEditor 5 in Drupal 9

The Basic page after saving with CKEditor 5
Basic page after saving with CKEditor 5 in Drupal 9

Edit the same test page but switch the text format to use the Restricted HTML with ACE Editor.
ACE Editor in Drupal 9

For sure Site admins needs to un-check the "Limit allowed HTML tags and correct faulty HTML" checkbox which is not recommended. Or follow up with the "Allowed HTML tags" to have only the needed allowed tags.

rajab natshah’s picture

Assigned: Unassigned » interdruper
Issue tags: +ace_editor-2.0.0-alpha1
rajab natshah’s picture

Assigned: interdruper » Unassigned
rajab natshah’s picture

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.