Problem/Motivation

This module is still using the old README.txt format.

We could update it to follow the pattern in the README.md template.

Steps to reproduce

Proposed resolution

  • Update format to Markdown
  • Add tip about disabling "Redirect users on logout" if using LDAP SSO module
  • Update Maintainers list

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 Masquerade.PNG40.07 KBkavitha89

Issue fork masquerade-3330972

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jay Jangid created an issue. See original summary.

Jay Jangid opened merge request !6

jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
Status: Active » Needs review

I Create a MR please review.
Thank you.

kavitha89’s picture

kavitha89 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Masquerade.PNG40.07 KB

The patch works fine. Moving it to RTBC

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Change README.txt to README.md and update according to "README.md template" in 8.x-2.x branch. » Change README.txt to README.md and update according to "README.md template"
Status: Reviewed & tested by the community » Needs review

Since the last reviewer does not pay much attention to details, it would be better somebody else reviews the MR.

ressa’s picture

ressa
he/him
commented

Thanks for reverting these @apaderno. Please see also my comment in #3374414-2: Disturbing behavior by Specbee employee for another Specbee employee (nupur-badola) with same behavior.

clarkssquared’s picture

clarkssquared commented

Hi jay jangid,

I looked at the README content and added a comment regarding line #3 which it exceeds the 80 character line limit. Please check.

ressa’s picture

ressa
he/him
commented

I think the most basic steps to use this module should be added. It's not stated on the project page, nor is there a link to a documentation page ... (maybe there isn't one?)

This is pretty crucial information, so maybe someone can review it, so we can get this committed and released?

ressa’s picture

ressa
he/him
commented
Issue summary: View changes

I added a tip about disabling "Redirect users on logout" if using LDAP SSO module.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Gonna commit it with #3587101: Convert hooks and add Drupal 12 compatibility and publish 2.2 release later today

  • andypost committed 8de24c5e on 8.x-2.x authored by jay jangid 
    feat: #3330972 Change README.txt to README.md and update according to "...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Thank you, merged and created https://www.drupal.org/project/masquerade/releases/8.x-2.2

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

ressa’s picture

ressa
he/him
commented

Fantastic, thank you so much for maintaining Masquerade @andypost, I really appreciate it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.