Primary button has white color border, on a white background can be an accessibility issue because it can make it difficult for users with visual impairments to see the button or distinguish it from the surrounding content.

Also on hover, button has --color--primary-30 border color, on hover there is movement on the button.

Check screenshot for reference.

Proposed solution:
We can add a border-color to the button on initial state.

CommentFileSizeAuthor
Screenshot 2023-01-04 at 1.30.29 PM.png362.26 KBgauravvvv

Issue fork drupal-3330961

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Issue summary: View changes

vinitk made their first commit to this issue’s fork.

vinitk opened merge request !3193

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Confirmed the issue. Makes the button appear slightly smaller then the input.

MR fixes the issue.

  • lauriii committed f742461a on 10.1.x 
    Issue #3330961 by vinitk, smustgrave: Olivero: Primary button has white...

lauriii closed merge request !3193

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed f742461 and pushed to 10.1.x. Thanks!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Updating credits

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.