Problem/Motivation

Change readme.txt to readme.md and update content

Proposed resolution

Remove Readme.txt and create Readme.md and update content

CommentFileSizeAuthor
#12 3330589 - after.png410.54 KBkenyoowen
#12 3330589 - before.png385.31 KBkenyoowen
#10 Node export_readme.PNG15.09 KBkavitha89

Issue fork node_export-3330589

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Dheeraj Jhamtani created an issue. See original summary.

Dheeraj Jhamtani opened merge request !3

dheeraj jhamtani’s picture

dheeraj jhamtani commented
Assigned: dheeraj jhamtani » Unassigned
Status: Active » Needs review

Please review this MR.

ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Thanks looks great, just a detail about links under "Maintainers" section:

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Should be in this format:
- Peter Wolanin - [pwolanin](https://www.drupal.org/u/pwolanin)

_pratik_ made their first commit to this issue’s fork.

dheeraj jhamtani’s picture

dheeraj jhamtani commented
Status: Needs work » Needs review

Sonal Gyanani made their first commit to this issue’s fork.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Needs work

Why USAGE section is removed/missed while updating content in README.

Sonal Gyanani’s picture

Sonal Gyanani commented
Status: Needs work » Needs review

Thanks @Manoj Raj.R, added usage section.
Please review

kavitha89’s picture

kavitha89 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Node export_readme.PNG15.09 KB

The patch works fine and moving it to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

Since the last reviewer does not pay much attention to details, it would be better somebody else reviews the MR.

kenyoowen’s picture

kenyoowen commented
StatusFileSize
new 3330589 - before.png385.31 KB
new 3330589 - after.png410.54 KB

Hi Sonal Gyanani

I applied and reviewed your MR and confirmed that README.txt is replaced with README.md, but the maintainer section has missing information since the module has 5 maintainers. Please look at the screenshot I attached for your reference

Thank you

kenyoowen’s picture

kenyoowen commented
Priority: Normal » Minor
Status: Needs review » Needs work

Anjali Mehta made their first commit to this issue’s fork.

anjali mehta’s picture

anjali mehta commented
Status: Needs work » Needs review

Added changes to readme.md file.
Kindly review the changes.
Thank You.

nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR!3, readme.md file is updated as per readme.md file template. Moving it to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work
anjali mehta’s picture

anjali mehta commented
Status: Needs work » Needs review

Kindly Review the changes.
ThankYou

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Title: Change readme.txt to readme.md and update content » Change readme.txt to readme.md and update content
Status: Needs review » Reviewed & tested by the community

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.