Problem/Motivation

I have a site in which users can authenticate through openid_connect, but when a user tries to log in he gets the following error: 

RuntimeException: User already logged in in Drupal\openid_connect\OpenIDConnect->completeAuthorization() (line 303 of modules/contrib/openid_connect/src/OpenIDConnect.php).

Drupal\openid_connect\Controller\OpenIDConnectRedirectController->authenticate('legis_sso')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 49)
Drupal\remove_http_headers\StackMiddleware\RemoveHttpHeadersMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Therefore it is not possible to log in correctly, what can I do in this case?

CommentFileSizeAuthor
#4 3329847-openid-runtimeexception.patch910 bytesrakshith.thotada
#3 3329847-openid-runtimeexception.patch3.28 KBrakshith.thotada

Comments

LeJuanChis created an issue. See original summary.

lejuanchis’s picture

lejuanchis commented
Issue summary: View changes
rakshith.thotada’s picture

rakshith.thotada commented
StatusFileSize
new 3329847-openid-runtimeexception.patch3.28 KB

Adding try catch exception to handle already logged in Users.

rakshith.thotada’s picture

rakshith.thotada commented
StatusFileSize
new 3329847-openid-runtimeexception.patch910 bytes

Updated Patch

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Needs work

The suggested code could definitively be better.

The code now is saying, an unknown error occurred since the user is already logged in, and throws an exception to be handled by a higher-level code that knows what is happening. The suggested code immediately grabs that exception (making it useless), and logs a warning. Way better to never throw the exception at all if that's the suggested improvement. Or let the exception as is, and catch it where the call was made.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Closed (duplicate)

Seems like this is now a duplicate of #3265805: Make login not fail when user is already logged in