Closed (fixed)
Project:
Views Save Search Filter
Version:
1.0.0-alpha1
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Dec 2022 at 06:28 UTC
Updated:
9 Apr 2023 at 13:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
anoopsingh92Please review the patch.
Comment #3
anoopsingh92Comment #4
ressaThanks, please follow the pattern under "README format" in the README.md template.
Please create an issue fork (click "Create issue fork") and commit to that, for easier preview.
Comment #6
anoopsingh92Changes are committed You can preview them now.
Comment #8
lucienchalom commentedI reviewed and fixed the missing newline at the end of the file and a couple of misspelling.
hope is okay now =)
Comment #9
ressaThanks to both of you! I still see issues, such as:
Please refer to these lists for required sections and formatting:
Comment #10
lucienchalom commentedThank you for the review!
I am not sure about marking as a code, so I used markdown reference.
Comment #11
ressaThanks @lucienchalom, that was what I meant, so that was perfect. Still a few details in the list ...
Comment #12
lucienchalom commentedFixed the list! =)
I havent found any leading spaces tho.... sorry
Comment #13
ressaThey're in the list :)
Should be:
Comment #14
lucienchalom commented=O
I looked at the end of the line only, sorry.
also, i found in the https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...
that the numbered list uses like this
Should i change that too?
Comment #15
ressaNo problem, it was easily over-looked, since it was only a single space character :)
Yes please, about using just
1.'s in the ordered list. It makes them easier create and update.Comment #16
lucienchalom commentedAwesome!
fixed the numbered list then. =)
Comment #17
ressaLooks great, thanks @anoopsingh92 and @lucienchalom!
Comment #21
rajeshreeputraThank you for working on this, merged, release will follow shortly.