Update README.txt

Follow the pattern in the README.md template.

- Field, 
- so this added element generates a google map in the webform frontend and allows 
- you to select your location on the map which then collects your latlong 
+ Field, so this added element generates a google map in the webform frontend and
+ allows you to select your location on the map which then collects your latlong
- functionality 
- to add the google map api keys from the admin settings only.
+ functionality to add the google map api keys from the admin settings only.
+ 
+ 
+ MAINTAINERS
+ ---------------
+
+ Pravin Gaikwad (Rajeshreeputra) - https://www.drupal.org/u/rajeshreeputra
+ Ganesh Suryawanshi (ganeshsurya11) - https://www.drupal.org/u/ganeshsurya11
CommentFileSizeAuthor
#5 3329655-webform_gmap_field-4.patch2.66 KBanoopsingh92
#4 3329655-webform_gmap_field-2.patch1.6 KBanoopsingh92

Issue fork webform_gmap_field-3329655

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anoopsingh92 created an issue. See original summary.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Issue summary: View changes
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Issue summary: View changes
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3329655-webform_gmap_field-2.patch1.6 KB

Please review the patch.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Priority: Normal » Minor
StatusFileSize
new 3329655-webform_gmap_field-4.patch2.66 KB

Re-rolled the patch, Please review this.

ressa’s picture

ressa
he/him
commented
Issue summary: View changes
Status: Needs review » Needs work

Thanks @anoopsingh92, looks good!

Please follow the pattern under "README format" in the README.md template:

  1. The name is missing and some headers with ### should be ##.
  2. Please create an issue fork (click "Create issue fork") and commit to that, for easier preview and commenting.
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented

Changes are committed you can check https://git.drupalcode.org/issue/webform_gmap_field-3329655/-/commit/54b... here.

Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Status: Needs work » Needs review
ressa’s picture

ressa
he/him
commented
Status: Needs review » Needs work

Thanks, that looks better. Please:

  • Add module name
  • Turn these into well formatted links:
    [Webform] - https://www.drupal.org/project/webform
[Simple Google Maps] - https://www.drupal.org/project/simple_gmap
    Links should have a meaningful link text, for example: [Drupal](https://www.drupal.org/) (i.e. not just the URL)

    See: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

  • The line break messes up the link:
    [Installing Drupal Modules](https://www.drupal.org/docs/extending-drupal/
installing-drupal-modules).
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

Can we have MR for smooth merge followed by release.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented

Hi @rajeshreeputra, I have committed the changes directly on 1.0.x, you can check my commit url on #7.

Changes has been done for this module. Otherwise you can download the module from 1.0.x branch and then check the changes. It has been fixed because in this ticket there is no custom branch to create an MR that's why I have pushed directly on 1.0.x branch. So now you can fixed that ticket after verify. Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Status: Needs work » Reviewed & tested by the community

Rajeshreeputra opened merge request !2

  • Rajeshreeputra committed 051be468 on 1.0.x 
    Issue #3329655 by anoopsingh92, ressa, Rajeshreeputra, ganeshsurya11:...

Rajeshreeputra credited ganeshsurya11.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Reviewed & tested by the community » Fixed

Thank you for working on this, merged, release will follow shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.