Problem/Motivation
#3304820: Drupal 10 compatibility fixes introduced a new dependency, but it's not enabled on existing sites, causing erros and php notices due to the missing library.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | geolocation-n3328967-5.patch | 863 bytes | damienmckenna |
| #2 | geolocation-jquery-ui-autocomplete-3328967-2.patch | 547 bytes | berdir |
Comments
Comment #2
berdirHere's a patch, similar to existing ones in the module. Note that you do not need to do a cache clear in update functions like previous ones did, Drupal will automatically do that after running updates.
Comment #3
nick hope commentedAfter updating to Geolocation 3.11 with Drupal 9.5.0 and running update.php I was seeing warnings on /admin/reports/updates that the jquery_ui_autocomplete and jquery_ui_menu themes were missing. Patch #2 fixes that for me. Thank you @Berdir. I will post this as a related issue and probable solution on the issue that has popped up in the jquery_ui_autocomplete issue queue.
Here is the full warning I was seeing on /admin/reports/updates:
Comment #4
damienmckennaIt also needs to be listed as a dependency in composer.json so that it gets picked up via Composer.
Comment #5
damienmckennaThis includes the necessary composer.json change.
Comment #6
damienmckennaFYI when I run "composer validate" it gives this error:
This comes from the require-dev lines that are unnecessary IMHO.
Comment #7
damienmckennaI opened a separate issue for the composer problem: #3330861: Fix composer validation errors
Comment #8
damienmckennaFYI the change to add the new dependency triggers the problem with the composer.json file, as can be seen by the drupalci status: "PHP 8.1 & MySQL 5.7 updated deps, D9.4 Composer require-dev failure"
Comment #9
nick hope commentedPatch #5 still works for me with Geolocation 3.11 with Drupal 9.5.0. Thank you @DamienMcKenna.
Comment #11
christianadamski commentedThis is annoying. Anyway, thanks for your help, patch applied.
Comment #12
nick hope commentedThe comment in the patch (which ends up at line 200 in geolocation.install) should be
// Enable jquery_ui_autocomplete., not// Enable geolocation_google_maps. (which has presumably been copied and pasted from the top of geolocation.install). Not a big deal but it may confuse someone later.Edit: I'll make a revised patch and reopen.
Comment #13
nick hope commentedComment #14
nick hope commented#12 addressed in https://www.drupal.org/project/geolocation/issues/3331671.
Comment #15
jjancel commentedgood morning
No patch works
auto-update error above version 8.x-3.10
What is happening ?
why this jquery_ui_autocomplete dependency
UNRESOLVED DEPENDENCY
jquery_ui (missing)
Geolocation needs this module.
Geolocation - Leaflet needs this module.
UNRESOLVED DEPENDENCY
jquery_ui_autocomplete (missing)
Geolocation needs this module.
Geolocation - Leaflet needs this module.
Is there another module to display a coordinate with Leaflet
Merci
Comment #17
jjancel commentedhello
the latest version does not work
Comment #18
jjancel commentedHello
after research i solved the problem by installing the module https://www.drupal.org/project/jquery_ui_autocomplete
it would be nice if the dependencies were indicated in the description
Comment #19
therobyouknow commentedAgree with https://www.drupal.org/project/geolocation/issues/3328967#comment-14924312
In turn, I had to composer install a later version of jquery_ui
I got it working. Here are my failures, then my successes and my composer.json file:
my failures:
now, my successes:
essentially these worked:
full command output of above:
my composer.json file