Problem/Motivation

This is related to this issue reported for simplytest project.

When the module is installed using composer, the folder getting downloaded in modules/contrib is named 'views_fractionslider'. Even the composer command is using the same name.composer require 'drupal/views_fractionslider'. But if we try to install the module using drush drush pm:install views_fractionslider, drush will throw error because the .info.yml file of the module is named fractionslider.info.yml. This seems to be confusing. Can we update the folder name and composer command to just "fractionslider" and composer require 'drupal/fractionslider' or change the machine name to "views_fractionslider"?

Steps to reproduce

  1. composer require 'drupal/views_fractionslider'
  2. drush pm:install views_fractionslider

Proposed resolution

Update the module name accordingly

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork views_fractionslider-3328794

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Akhil Babu created an issue. See original summary.

Deepak Tomar made their first commit to this issue’s fork.

Deepak Tomar opened merge request !1

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Machine name and 'Folder' name of the modue are different » The project machine name isn't used in filename and hook function names
Category: Feature request » Bug report

This is a bug: If views_fractionslider is the project machine name, there must be a views_fractionslider.info.yml file, not fractionslider.info.yml; any hook implemented by the module has a name that starts with views_fractionslider_, not fractionslider_.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: The project machine name isn't used in filename and hook function names » The project machine name isn't used in filenames and hook function names

monymirza closed merge request !1

sonvir249 made their first commit to this issue’s fork.

sonvir249 opened merge request !2

sonvir249’s picture

sonvir249 commented
Status: Active » Needs review
monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Version: 8.x-1.x-dev » 2.2.0
Status: Needs review » Fixed

Already Fixed in V2 stable branch.

sonvir249’s picture

sonvir249 commented
Status: Fixed » Needs review

@monymirza in V2 stable branch file names are fractionslider.info.yml, fractionslider.libraries.yml and fractionslider.module. It sould follow the module directory name.

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs review » Needs work