Problem/Motivation
Currently we have two options for the Accordion / Tabs Paragraphs bundle:
- Accordion
- Tabs (become Accordion on small devices)
In some cases it makes sense to have tabs also on small devices.
Steps to reproduce
Proposed resolution
Add "Tabs" as third option.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 2022-12-22 11_31_49-field.field_.paragraph.container_tabs_accordion.field_paragraphs_tabs_acc_type.ym_.png | 12.47 KB | grevil |
Issue fork drowl_paragraphs-3328592
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
anybody+1 good idea
Comment #3
anybody@Grevil can do the code review.
Comment #4
grevil commentedThis is a submodule issue!
Comment #5
grevil commentedComment #6
grevil commentedValue should be called:
Comment #7
anybody@Grevil: Here's the boilerplate code for the update hook in the submodule:
https://drupal.stackexchange.com/a/307268/47035
Something like this:
And don't forget the
save()xDThis is how it looks like in the yml:
Please add a snippet for us and at https://www.drupal.org/docs/drupal-apis/update-api/updating-entities-and...
Comment #8
thomas.frobieterTwig template is already fixed: https://git.drupalcode.org/issue/drowl_paragraphs-3328592/-/commit/9039a...
Comment #9
thomas.frobieterComment #11
grevil commentedOn an unrelated note, there are 66 occurences of "accordion" inside "config/install" and 55 occurences of "accordeon"...
Maybe we mixed that up at one point with the German word "Akkordeon"? But "Accordion" is the correct english name
Comment #12
anybody@Grevil thanks, Accordion is correct in English! Should be corrected, where it is just a string. If functionality is affected, it should please not be changed. Not worth the trouble.
And please create a small separate issue for that.
Comment #13
grevil commentedAny other "field.field.paragraph.container_tabs_accordion.[...].ymls which need this entry? Or only "field_paragraphs_tabs_acc_type"?
See:

Comment #14
grevil commentedFurthermore I am really confused with the description of this issue:
So we want 3 Options? What is the third one, if there are already 2? And where are these two options set? Not in "field.field.paragraph.container_tabs_accordion.field_paragraphs_tabs_acc_type.yml". And why does the example of @Anybody adds two options?
Comment #15
grevil commentedOK, I hope the MR is what you expect! I'll have to test it locally first.
Comment #16
anybody@Grevil: Commented. Looking good, hope it works :)
For testing you have to ensure you're installing the module before applying this patch of course.
Comment #17
grevil commentedPlease review
Comment #18
anybodyRTBC after fixing the last comment.
Please create a new 4.2.20 release afterwards. Be careful with the branches.
Comment #20
grevil commented