Problem/Motivation

The fix in #3278542: Update $logger definition to be compatible with Drupal 10 is necessary for true Drupal 10 support, and even though it has been committed a few months ago, there is still no release that includes that fix.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 fix-drush-crash.patch443 bytesmindaugasd

Comments

jcnventura created an issue. See original summary.

mindaugasd’s picture

Sending patch for 1.16 to prevent module from crashing drush while where is no release.

Commit in that issue creates a different crash, so therefor made this simpler patch.

jcnventura’s picture

The commit did the proper fix to the issue, but it does remove one service injection, so maybe some caches may need to be cleared. In any case, it would be good if you could reveal which "different crash" got created by applying that change, as it might be useful to fix that before 1.17 is created.

mindaugasd’s picture

I tried to recreate the error, and found the problem with the site itself (weird directory structure and duplicated modules).
And this patch I made it by copying it from another module issue queue without looking into details.
So green light from me. Original commit does not seem to create another error.

kreynen’s picture

Related issues: +#3320557: D10 Readiness
rlhawk’s picture

Status: Active » Fixed

Thanks for the reminder about creating a release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.