Problem/Motivation

There have been a number of changes made to 8.x-3.x for D8 + D9

https://www.drupal.org/project/module_filter/releases/8.x-3.x-dev

Also started a new 4.x branch for D9 + D10

https://www.drupal.org/project/module_filter/releases/4.x-dev

Both need testing!

Steps to reproduce

NA

Proposed resolution

TEST TEST

Remaining tasks

Do the test

User interface changes

NA

API changes

NA

Data model changes

NA

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Issue summary: View changes
jonathan1055’s picture

jonathan1055 commented

I've just switched to the 4.x dev branch locally, and all seems OK on D9.5.
It needed composer require drupal/jquery_ui_autocomplete as mentioned in #3297692-11: Automated Drupal 10 compatibility fixes.

It would be good to have more automated tests, so that we can be more confident about code changes. I will open an issue to discuss that.

jonathan1055’s picture

jonathan1055 commented
Related issues: +#3328058: Expand the phpunit test coverage for module_filter

I have raised #3328058: Expand the phpunit test coverage for module_filter to discuss it.

smustgrave’s picture

smustgrave commented
Status: Active » Fixed

Thanks for the quick testing. Tagged both 8.x and 4.x for a new release.

But the additional tests sound like a great idea.

CyrilC’s picture

CyrilC commented

Hello, installed on a fresh D10 install with 4.x and the tabs don't show up on the modules page.

Checked the configuration and the 'enhance with tabs' is checked. Cleared the cache and still no tabs. The search bar is longer and the check boxes for enabled/disabled/unavailable are there, so it appears that Module Filter is working in that way. Then when I search the accordion package titles don't disappear as they do with core's search.

smustgrave’s picture

smustgrave commented

Reverted #3186276: Javascript behaviour should only be ran once (results in nested tabs)

Can you try again please.

CyrilC’s picture

CyrilC commented

Working on D10 and 4.0.1.

jonathan1055’s picture

jonathan1055 commented

Sorry @smustgrave, I only tested 4.x on Drupal 9.5 not 10.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.