Problem/Motivation

The module has low automated test coverage, placing a burden to test changes manually. Bugs can be introduced and get missed.

Automated tests are needed for:

Extend page

  • Testing that the tabs for core appear
  • Testing recently enabled and newly available tabs appear
  • Install a random core module and see that it appears in 'recently enabled' tab
  • Test that a new module appears in the 'newly available' tab
  • Test the filter for title, machine name, and description (functional javascript) [done]

Uninstall

  • Test for filter input
  • Test filter for title and description (functional javascript) [done]

Available Updates

  • Test for filter text input [done]
  • Test radio button [done] (added a javascript test to cover both of these)

Permissions

  • Test for filter input
  • Test filter on module name (functional javascript) [done]

Module Settings

  • Test the settings form (Kernel) [done]

Issue fork module_filter-3328058

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

smustgrave’s picture

smustgrave commented

Think we could use a functional test for the UI/functionality

Extend page

Testing that the tabs for core appear
Testing recently enabled and newly available tabs appear
Install a random core module and see that it appears in recently enabled
Not sure how but use maybe admin_toolbar to see if newly available works.
Test the filter for title, machine name, and description.

Uninstall

Test for filter input
Test filter

Available Updates

Test for filter input
Test filter

May be a good start?

jonathan1055’s picture

jonathan1055 commented

That's an excellent start. As it happens I have just started work on a function test for your change on #3327899: Filter on module description (module_filter). Its a functionalJavascript test so that it can check the filter result on entry of the text. I have created a ModuleFilterJavascriptTestBase class too. Not working yet, but I'll add a MR here to share and get your feedback.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Updated issue summary, with what you added in #2 and added a bit more detail. This is not a definitive list, necessarily.

I'm going to work on a javascript test for the permissions filter, as that is needed before any more work on #3331723: Filter permissions on description not just module name

jonathan1055 opened merge request !23

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

Permissions filter test added, ready for review.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes
Status: Needs review » Active

Thanks for merging.
Putting this issue back to Active.

jonathan1055’s picture

jonathan1055 commented
Issue summary: View changes

Updated IS for tests added in #3413467: Radio buttons on Available updates report do nothing

smustgrave’s picture

smustgrave commented

So is the tests for the extend page all that is missing you would say?

smustgrave’s picture

smustgrave commented
Status: Active » Fixed
Related issues: +#3455083: Finish up test coverage

Believe we are good with coverage!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.