Problem/Motivation

The module only supports checking links in the "main" menu. This means it doesn't match menu links against

Steps to reproduce

Add a second menu structure.
Add nodes to that menu so that there is a menu tree with node1/node2/node3.
View node3.

Expected results:
* The breadcrumbs uses the labels from the menus.

What actually happens:
* The menu tree is ignored.

Proposed resolution

Add a settings form complete with menu link that goes under Admin → Configuration → User interface.
Include a default configuration in config/install and a schema file in config/schema.
Copy the menu selection logic from the Menu Breadcrumb module.
Extend the logic in BreadcrumbBuilder::build() to check each of the menus configured.

Remaining tasks

Provide a patch / MR.

User interface changes

A settings page would be provided for controlling which of the menus would be allowed, along with their order.

API changes

TBD

Data model changes

TBD

Issue fork breadcrumb_menu-3327634

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The module Menu Breadcrumb has a settings page and logic for this, it could be borrowed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes

makertimswis made their first commit to this issue’s fork.

makertimswis opened merge request !4

casey made their first commit to this issue’s fork.

  • casey committed 66748cd6 on 8.x-1.x 
    Issue #3327634: Use LF newlines

  • casey committed c9adca01 on 8.x-1.x 
    Issue #3327634: Add initial settings

  • casey committed f254cfb1 on 8.x-1.x 
    Issue #3327634: Add menu_active_trails cache context for all menus

  • casey committed ebf724e6 on 8.x-1.x 
    Issue #3327634: Rename config_form to settings

  • makertimswis committed 36bee8ae on 8.x-1.x 
    Issue #3327634: Introduce module configuration and add support for other...
casey’s picture

casey commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.