Problem/Motivation

In a multilingual site, when "Separation of Tags per language" is enabled you have your tag clouds showing per language tags, and it's OK. But if there are some vocabularies without language (for example a numeric vocabulary, a postal code vocabulary, etc.) then this cloud is shown empty.

Proposed resolution

The "Separation of Tags per language" should only apply to per language vocabularies.

Issue fork tagclouds-3327145

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

calbasi created an issue. See original summary.

calbasi’s picture

calbasi
Primary language Catalan
Location Catalonia
commented
Title: Tags froma vopcabulary without language not shown when "Separation of Tags per language" is enabled » Tags from a vocabulary without language not shown when "Separation of Tags per language" is enabled
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@calbasi, do you have a patch we can review? Or are you planning on uploading a patch or suggesting a change that will work for everyone?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs work
calbasi’s picture

calbasi
Primary language Catalan
Location Catalonia
commented

I'm not coder, but maybe I could try to do it just to learn some php if nobody else want to try to solve it.

grask0’s picture

grask0 commented
Version: 2.0.2 » 2.0.x-dev
Assigned: Unassigned » grask0

andriy parkhomiuk opened merge request !12

grask0’s picture

grask0 commented
Assigned: grask0 » Unassigned
Status: Needs work » Needs review

Hello all,

I added the logic to display taxonomy terms according to language. If taxonomy vocabulary(ies) are non-translatable, then display the default term name.
It'd be great to review my code and test such functionality.

Thanks!

o_timoshchuk’s picture

o_timoshchuk commented
Assigned: Unassigned » o_timoshchuk
o_timoshchuk’s picture

o_timoshchuk commented
Assigned: o_timoshchuk » Unassigned
Status: Needs review » Reviewed & tested by the community

I've tested the new logic, and it's working well for me

joseph.olstad closed merge request !12

  • joseph.olstad committed 52a56f37 on 2.0.x 
    fix: #3327145 Tags from a vocabulary without language not shown when '...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.