Some time between 20 and 24 November the three Scheduler tests involving Rules started failing. The log just says:

Scheduler_rules_integration.Drupal\Tests\scheduler_rules_integration\Functional\SchedulerRulesEventsTest
Drupal\Tests\scheduler_rules_integration\Functional\SchedulerRulesEventsTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-1.xml:
PHPUnit Test failed to complete; Error: PHPUnit 8.5.26

Same problem with SchedulerRulesConditionsTest and SchedulerRulesActionsTest

Issue fork scheduler-3326114

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

Title: Rules tests fail at 9.4 » Scheduler Rules Integration tests fail at 9.4

Going to commit the change to skip the Rules tests, to get the 2.x branch passing again.
This issue and MR can remain open to allow checking of the Rules tests later.

  • jonathan1055 committed 209043e on 2.x
    Issue #3326114 by jonathan1055: Skip running Rules Integration tests
    
jonathan1055’s picture

The rules tests pass on 8.x-1.x running php7.3 on D9.4

Both 8.x-1.x and 2.x are attempting to get the latest 3.x-dev version of Rules because Rules 3.0.0-alpha7 is not compatible with PHP8.1. However, the dispatch log for both the passing and failing jobs on PHP7.3 have:

cd ${SOURCE_DIR} && sudo -u www-data composer require drupal/rules:3.x-dev
./composer.json has been updated
Running composer update drupal/rules
> Drupal\Composer\Composer::ensureComposerVersion
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- mglaman/phpstan-drupal is locked to version 1.1.25 and an update of this package was not requested.
- mglaman/phpstan-drupal 1.1.25 requires php ^7.4 || ^8.0 -> your php version (7.3.33) does not satisfy that requirement.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Does this mean that Rules is not updated to use 3.x-dev?

jonathan1055’s picture

Running at PHP8.1 we get

cd ${SOURCE_DIR} && sudo -u www-data composer require drupal/rules:3.x-dev
./composer.json has been updated
Running composer update drupal/rules
> Drupal\Composer\Composer::ensureComposerVersion
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
- Upgrading drupal/rules (3.0.0-alpha7 => dev-3.x 9595fca)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
- Syncing drupal/rules (dev-3.x 9595fca) into cache
- Removing drupal/rules (3.0.0-alpha7)
- Installing drupal/rules (dev-3.x 9595fca): Cloning 9595fcaf4a from cache

so the Rules module is updated to the latest 3.x-dev and the Rules tests all pass OK.

jonathan1055’s picture

That worked. Adding mglaman/phpstan-drupal:* specifically with the * allowed a downgrade, which meant that the update to Rules 3.x-dev was not reverted. The test passed. We get:

cd ${SOURCE_DIR} && sudo -u www-data composer require drupal/rules:3.x-dev mglaman/phpstan-drupal:*
mglaman/phpstan-drupal is currently present in the require-dev key and you ran the command without the --dev flag, which would move it to the require key.
./composer.json has been updated
Running composer update drupal/rules mglaman/phpstan-drupal
> Drupal\Composer\Composer::ensureComposerVersion
Loading composer repositories with package information
Updating dependencies
Lock file operations: 2 installs, 2 updates, 0 removals
- Upgrading drupal/rules (3.0.0-alpha7 => dev-3.x 9595fca)
- Downgrading mglaman/phpstan-drupal (1.1.25 => 1.1.4)
- Locking nette/finder (v2.5.4)
- Locking nette/utils (v3.2.8)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 2 updates, 0 removals
- Syncing drupal/rules (dev-3.x 9595fca) into cache
jonathan1055’s picture

Adding --dev works fine too, just get the message the other way round.

cd ${SOURCE_DIR} && sudo -u www-data composer require --dev drupal/rules:3.x-dev mglaman/phpstan-drupal:*
drupal/rules is currently present in the require key and you ran the command with the --dev flag, which would move it to the require-dev key.

  • 4adf27e committed on 2.x
    Issue #3326114 by jonathan1055: Scheduler Rules Integration tests fail...
jonathan1055’s picture

Title: Scheduler Rules Integration tests fail at 9.4 » Scheduler Rules Integration tests fail at PHP7.3, ok at PHP8.1
Status: Active » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.