jQuery 3.3+ breaks autocomplete

Thanks! Can we address this in jquery_update instead?

Apart from anything else, the lack of any JS testing in D7 means it'd be preferable not to change D7 core to cater for the small (?) number of sites running up-to-date jQuery 3.x

Erm, yeah I'm not sure why that's happened.

A quick way to try and see what's going on is something like this (with and without the patch applied):

$ drush -y si && drush -y en jquery_update && drush -y vset jquery_update_jquery_version '2.2'

$ drush ev "print_r(drupal_get_library('system')['jquery']);"
Array
(
    [title] => jQuery
    [website] => http://jquery.com
    [version] => 2.2.4    // <== this is what we're testing, IIUC
    [js] => Array
        (
            [misc/jquery.js] => Array
                (
                    [group] => -100
                    [weight] => -20
                    [data] => sites/all/modules/contrib/jquery_update/replace/jquery/2.2/jquery.min.js
                    [version] => 2.2.4
                )

            [misc/jquery-extend-3.4.0.js] => Array
                (
                    [group] => -100
                    [weight] => -19
                    [version] => 2.2.4
                )

            [misc/jquery-html-prefilter-3.5.0-backport.js] => Array
                (
                    [group] => -100
                    [weight] => -19
                    [version] => 2.2.4
                )

        )

    [dependencies] => Array
        (
            [0] => Array
                (
                    [0] => jquery_update
                    [1] => jquery_update.browser.fix
                )

        )

    [css] => Array
        (
        )

)

$ drush ev "print_r(drupal_get_library('system')['drupal.ajax']['js']);"
Array
(
    [misc/ajax.js] => Array
        (
            [group] => -100
            [weight] => 2
            [version] => 7.94-dev
        )

    [0] => Array
        (
            [data] => Array
                (
                    [ajaxPageState] => Array
                        (
                            [jquery_version] => 2.2  // <== this is what we're testing, IIUC 
                            [jquery_version_token] => _cQ*****token******t0
                        )

                )

            [type] => setting
            [version] => 7.94-dev
        )

)

I can imagine the patch moving things around in $libraries a little, but don't see how it'd cause these specific assertions to fail.

Generally the patch looks like the right sort of idea, but I've not looked too closely yet.

I've queued the tests to re-run. If the result's the same we may need to look closely using an actual drupalci instance.

I do have a local drupalci I can start testing this with (see https://www.drupal.org/drupalorg/docs/drupal-ci/running-drupalci-locally ).

Here's a quick tweak to the patch just to see if the main drupalci will give us a clue about what's going wrong though...

fail: [Other] Line 405 of sites/all/modules/jquery_update/tests/jquery_update.test:
Failed jquery version: 1.12.4

fail: [Other] Line 407 of sites/all/modules/jquery_update/tests/jquery_update.test:
Failed ajax version: 1.12

Okay, so looks like the admin form submission to set the initial version for the test isn't working for some reason... not sure why that would be, but it gives us somewhere to start.

I think this is happening without any of the changes from this issue.

Here's a noop patch to check that.

If so, I don't understand why ... but it'd be good to know.

Filed #3327465: Fix broken tests to fix the broken tests. I don't want to commit / release anything until that's resolved.

If this patch fixes the issue with autocomplete that you initially noticed, that's great. Guessing it wouldn't be an easy thing to test in D7?

Will review this properly once tests are passing again; sorry for the delay.

Re-testing #6 now that #3327465: Fix broken tests is fixed.

Tests look good for #6 now.

@MustangGB can you please provide simple steps for how to review the fix manually?

I tried adding search_autocomplete to a vanilla D7 site with jquery_update bringing in the latest jQuery 3.6.x but it wasn't apparent that there was a problem with positioning in the UI.

Thanks for the detailed steps - took me quite a bit of fiddling around to get the multifield table widget working, but I was eventually able to reproduce the problem with autocomplete.

The fix looks good.

Sorry to be pedantic, but there is one thing I'd like to tweak though; I was sure we'd made some changes fairly recently relating to jQuery's position() and eventually remembered that I was thinking of SA-CORE-2022-001:

https://git.drupalcode.org/project/drupal/-/commit/c05bb17ce3a697cc36221...

We used quite a specific filename for that backport, and it bothers me slightly that the patch here is specifically addressing an issue with autocomplete (even more specifically Drupal.jsAC.prototype.populatePopup) but we're just calling it "position fix":

+    'title' => 'jQuery Update Position Fix',
+    'js' => array(
+      drupal_get_path('module', 'jquery_update') . '/js/jquery_position.js' => array(

The other similar shim that jQuery Update recently added is called jquery_browser.js but that does actually provide jquery.browser if it's no longer provided by jQuery.

Can we please name this shim / fix more specifically based on what it's actually doing?

Maybe more like "jQuery Update Autocomplete Position fix".

... as the thing that changed was the functionality of position() thought it made ... sense to go with jquery_update.position.fix, meaning all fixes related to position, it just so happens that the only place we've found to fix so far is in autocomplete, but in theory fixes for other elements could also go in this file.

Yup, okay that makes sense. Happy to leave it as it is.

Will do a final review and commit this ASAP. Thanks!

Thank you!

Will get a new point release out soon (before marking the old 7.x-2.x release as unsupported).