I'm using address field integration with manual pull from/push to address field. After a reverse geocoding, clicking on "push to address" button doesn't fill up provinces dropdown.
Attached patch is similar to the one on parent issue: it adds an Italy class that extends NominatimRoadFirstFormattingBase and modifies Nominatim geocoder plugin to take in account "ISO3166-2-lvl6" field from webservice (values are in the form "IT-AR" so "[country-code]-[county-code]).

CommentFileSizeAuthor
#8 geolocation_nominatim-italy-3325866-8.patch1.16 KBmaurizio.ganovelli
geolocation_nominatim-italy.patch2.27 KBmaurizio.ganovelli

Comments

maurizio.ganovelli created an issue. See original summary.

maurizio.ganovelli’s picture

maurizio.ganovelli
he/him
Primary language Italian
Location Arezzo
commented
Status: Active » Needs review

I'm changing status as a patch is present.

christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed
christianadamski’s picture

christianadamski commented

Thanks!

maurizio.ganovelli’s picture

maurizio.ganovelli
he/him
Primary language Italian
Location Arezzo
commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

maurizio.ganovelli’s picture

maurizio.ganovelli
he/him
Primary language Italian
Location Arezzo
commented
StatusFileSize
new geolocation_nominatim-italy-3325866-8.patch1.16 KB

I don't know if this is the right place to post, since issue is closed, but this patch needs a fix to avoid the php notice "Only variables should be passed by reference" on array_pop() function call.

christianadamski’s picture

christianadamski commented
Status: Closed (fixed) » Needs review

I'll look into it. Might take a few days. Thanks!

christianadamski’s picture

christianadamski commented
Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Fixed

Thanks, added to v3 & v4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.