My environment is named `local`. Before upgrading to 4.0.11 (second tab in the screenshot), the favicon shows a letter `l`. After upgrading (first tab in the screenshot), the favicon always shows `(`. I guess it’s taking the `(` from the version prefix, instead of the actual name of the environment.

CommentFileSizeAuthor
#11 pngout.png10.15 KBandrew.wang
#3 Screen Shot 2023-01-13 at 2.48.11 PM.png4.1 KBpcate
pngout.png35.89 KBandrew.wang

Issue fork environment_indicator-3325119

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andrew.wang created an issue. See original summary.

darktek’s picture

darktek commented

Same issue here :(

I created a patch in this thread so you can take a look and apply it to your current version: https://www.drupal.org/project/environment_indicator/issues/3324621#comm...

pcate’s picture

pcate commented
StatusFileSize
new Screen Shot 2023-01-13 at 2.48.11 PM.png4.1 KB

Seeing this as well.

prudloff made their first commit to this issue’s fork.

prudloff opened merge request !24

prudloff’s picture

prudloff commented
Status: Active » Needs review

The MR uses only the environment name to generate the favicon.

devkinetic’s picture

devkinetic commented
Status: Needs review » Reviewed & tested by the community

This patch actually tracks with the original functionality. There is another issue #3377164: JS adds "(()" on mobile which swaps the title and the version around, but the truth is, all we need is the first character of the title, so no version is needed at all.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Related issues: +#3324621: Make version indicator source and version indicator source fallback configurable.

This issue should probably be closed as a duplicate of #3324621: Make version indicator source and version indicator source fallback configurable..

isholgueras’s picture

isholgueras commented
Status: Reviewed & tested by the community » Needs work

I like the fix, but there is another place where this should be fixed in environment_indicator.module:94. @prudloff, Can you please add the same code there?

Thanks!

prudloff’s picture

prudloff commented
Status: Needs work » Needs review
Issue tags: +DrupalCon Lille 2023

I like the fix, but there is another place where this should be fixed in environment_indicator.module:94.

I don't think it needs to be fixed there, $title already takes its value from $active_environment->get('name').

This issue should probably be closed as a duplicate of #3324621: Make version indicator source and version indicator source fallback configurable..

The patch in #3324621: Make version indicator source and version indicator source fallback configurable. seems to remove the deployment identifier from everywhere the environment title is displayed.
The current MR only removes it from drupalSettings (because we don't want to use it to generate the favicon but we do want to display it in the toolbar).

andrew.wang’s picture

andrew.wang commented
Version: 4.0.11 » 4.x-dev
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new pngout.png10.15 KB

Looks good now after applying the patch:

The image shows a dark-themed computer interface, possibly a software application or web page. In the upper left corner, there’s an icon resembling a water droplet with an “A” inside it, likely the application’s logo. Next to this icon is the partially visible word “Administrat,” suggesting it might be part of “Administration” or “Administrator.” Below this, there’s a hamburger menu icon with three horizontal lines. In the bottom right corner, white text reads “(v2024.07.02) local,” indicating version information or local data reference.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

In case the maintainers were wondering, this merge request is compatible with the merge request in #3324621: Make version indicator source and version indicator source fallback configurable. and is not a duplicate.

This issue #3325119: Favicon always shows `(` after upgrading to 4.0.11 is strictly about the Favicon.

+1 for merging

  • isholgueras committed 64463677 on 4.x authored by prudloff 
    Issue #3325119 by prudloff, trackleft2, andrew.wang, pcate, devkinetic,...
isholgueras’s picture

isholgueras commented
Status: Reviewed & tested by the community » Fixed

I'm going to add this to the 4.0.20 release. Thanks for the work

isholgueras’s picture

isholgueras commented
Status: Fixed » Closed (fixed)