Amongst the "new" errors found when running PHPStan on level 2 is: PHPDoc tag @throws with type Foo is not subtype of Throwable
This child-issue exists to fix all of those.
- Run PHPStan on level 2 and see the above error amongst all others.
- Solve all of the the above mentioned reported errors.
- Run PHPStan on level 2 and don't see the above mentioned error any more.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | level2_POST-3324838.txt | 2.18 MB | spokje |
| #3 | level2_PRE.txt | 2.18 MB | spokje |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !3055
Comments
Comment #3
spokjeAttached out of
vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --xdebug --no-ansiwith lvl 2 before and after applying the MR.Comment #4
spokjeComment #5
mallezieThis looks good. Only PHPDoc changes, and fixes some baseline L2 issues.
Comment #7
xjmRemoving credit for unneeded merge or rebase.
Comment #11
xjmNice little cleanup. I reviewed it locally with
git diff --color-wordsand confirmed that it's mostly adding leading slashes or missing namespaces, or in one case correcting a typo.Committed to 10.1.x, and cherry-picked to 10.0.x and 9.5.x as a phpdoc improvement. Thanks!