Problem/Motivation

Currently, we are using many bitwise operations used for different if-clauses inside the module. This isn't very intuitive and should be replaced, with more comprehensible if clauses.

Example from the install file:

if (_image_captcha_check_setup(FALSE) & $image_captcha_error_no_gdlib)

Steps to reproduce

Proposed resolution

If possible, move the whole logic inside "_image_captcha_check_setup".

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork captcha-3324321

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Minor

Indeed that's crazy. Never seen this (in PHP) before. Hope it wasn't just meant as && but I guess it's indeed bitwise...

If there's a way to solve this better, we should do that. Still it's minor, but would be great, if someone could prepare a MR with a fix.

japerry made their first commit to this issue’s fork.

japerry opened merge request !152

  • japerry committed 26f8d7e4 on 2.x 
    fix: #3324321 Check for GD directly in the image CAPTCHA install...
japerry’s picture

japerry
Location KOMK
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.