PHP 8.1 Return and Argument type errors - SevenShores\Hubspot\Http\Response [#3323840]

Problem/Motivation

After updating php to version 8.1, there are problems with the required library hubspot/hubspot-php

Deprecated function: Return type of SevenShores\Hubspot\Http\Response::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in include() (line 9 of /var/www/vendor/hubspot/hubspot-php/src/Http/Response.php).

include('/var/www/vendor/hubspot/hubspot-php/src/Http/Response.php')

Deprecated function: Return type of SevenShores\Hubspot\Http\Response::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in include() (line 9 of /var/www/vendor/hubspot/hubspot-php/src/Http/Response.php)

Proposed resolution

Update hubspoth/hubspot-php to newest version

Issue fork hubspot-3323840

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3323840-php-8.1-deprecated changes, plain diff MR !8
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 November 2022 at 20:15

stella created an issue. See original summary.

Comment #2

25 November 2022 at 20:19

stella opened merge request !8

Comment #3

stella commented 25 November 2022 at 20:25

Status:

Active

» Needs review

Alternative composer patch if stuck before 7.4 EOL:

https://github.com/HubSpot/hubspot-php/pull/378

https://patch-diff.githubusercontent.com/raw/HubSpot/hubspot-php/pull/37...

            "hubspot/hubspot-php": {
                "PHP 8.1": "https://patch-diff.githubusercontent.com/raw/HubSpot/hubspot-php/pull/378.patch"
            }

Comment #4

6 June 2024 at 14:57

joaopauloscho made their first commit to this issue’s fork.

Comment #5

joaopauloscho commented 6 June 2024 at 15:31

Title:

PHP 8.1 Deprecated function: Return type of SevenShores\Hubspot\Http\Response::offsetExists($offset)

» PHP 8.1 Return and Argument type errors - SevenShores\Hubspot\Http\Response

I'm not sure if https://www.drupal.org/project/hubspot/issues/3388150 would be a duplicate of this but I'm adding psr/http-message:^1.1 as a requirement along with hubspot/hubspot-php:^5.0 . The reason of this is because the hubspot newest version (5.2) requires psr/http-message::^1.1 now. Please take a look, thanks!