Problem/Motivation

If the query runs and the results are empty, the results are set to null, yet ::sanitizeReport() is still run. ::sanitizeReport() does not check if there are results and this can therefore result in a fatal error.

Steps to reproduce

Run a query that returns no results.

Proposed resolution

Check if results exist before sanitising them.

Remaining tasks

Provide patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork google_analytics_counter-3323810

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !11

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Active » Needs review

Merge request created https://git.drupalcode.org/project/google_analytics_counter/-/merge_requ...

kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Status: Needs review » Fixed

Committed. Thanks for your help!

scott_euser’s picture

scott_euser commented

Great thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.