Problem/Motivation

A recent issue caused inline styles to be stripped. To avoid this in the future, we should include it in the functional tests. The standard test email already includes some inline styles, so we can easily add an assertion for it.

Steps to reproduce

n/a

Proposed resolution

Add an assertion to the TestEmailTest test case.

Remaining tasks

Review patch.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#5 interdiff_02-05.txt623 byteslucassc
#5 3323404-05.patch712 byteslucassc
#2 3323404-add-assertion-to-test-for-inline-styles.patch594 bytesseutje

Comments

seutje created an issue. See original summary.

seutje’s picture

seutje commented
Status: Active » Needs review
StatusFileSize
new 3323404-add-assertion-to-test-for-inline-styles.patch594 bytes

Added patch with assertion for the inline style included in the default test email.

seutje’s picture

seutje commented
Issue summary: View changes
adamps’s picture

adamps commented
Status: Needs review » Needs work

Thanks. Please can we have a comment saying

  • what we are doing: "check that inline styles are preserved in the email"
  • why these particular styles: "the padding is added in email-wrap.html.twig"
lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
Status: Needs work » Needs review
StatusFileSize
new 3323404-05.patch712 bytes
new interdiff_02-05.txt623 bytes

Comments added. Please, review.

  • AdamPS committed fe71509d on 1.x authored by seutje 
    Issue #3323404 by lucassc, seutje: Add assertion to test for inline...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.