Problem/Motivation

When using the version 2.0-alpha1 of focal_point module, we are receiving an error when creating a Document media.

Steps to reproduce

1. Go to /media/add/document
2. Upload a PDF file
3. Click on "Save"
4. The following exception will be thrown:
`TypeError: Drupal\focal_point\FocalPointManager::saveCropEntity(): Argument #3 ($width) must be of type int, null given, called in /var/www/web/modules/contrib/focal_point/focal_point.module on line 99 in Drupal\focal_point\FocalPointManager->saveCropEntity() (line 94 of /var/www/web/modules/contrib/focal_point/src/FocalPointManager.php)`

Proposed resolution

The function `saveCropEntity` has typed parameters in 2.0 version however, there is no width or height for the Documents thumbnail. We should allow nullable values for these parameters.

CommentFileSizeAuthor
#5 Screenshot 2022-12-16 at 9.09.39 PM.png584.47 KBankitv18
#5 Screenshot 2022-12-16 at 9.09.25 PM.png473.3 KBankitv18
#3 Screenshot 2022-11-23 at 12.04.30 PM.png835.57 KBArti Anil Pattewar
#3 Screenshot 2022-11-23 at 12.04.22 PM.png846.97 KBArti Anil Pattewar
#3 Screenshot 2022-11-23 at 12.04.13 PM.png851.91 KBArti Anil Pattewar
#2 media-document-issue-3323205-1.patch1.09 KBhfernandes

Issue fork focal_point-3323205

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hfernandes created an issue. See original summary.

hfernandes’s picture

hfernandes commented
Status: Active » Needs review
StatusFileSize
new media-document-issue-3323205-1.patch1.09 KB

Patch attached

Arti Anil Pattewar’s picture

Arti Anil Pattewar commented
StatusFileSize
new Screenshot 2022-11-23 at 12.04.13 PM.png851.91 KB
new Screenshot 2022-11-23 at 12.04.22 PM.png846.97 KB
new Screenshot 2022-11-23 at 12.04.30 PM.png835.57 KB

Not able to reproduce the issue.
installed focal point. cloned 2.0 from version control, installed all the dependency modules.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Assigned: hfernandes » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2022-12-16 at 9.09.25 PM.png473.3 KB
new Screenshot 2022-12-16 at 9.09.39 PM.png584.47 KB

Hi,
This issue is already covered in https://www.drupal.org/project/focal_point/issues/3295940.
We are good to close this one.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Reviewed & tested by the community » Fixed

Thanks for confirming, Closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.