Problem/Motivation

Config page is broken after site upgraded to Drupal 10.

Steps to reproduce

Upgrade or install Drupal 10 site.
Go to : /admin/config/search/xmlsitemap
You'll see

The website encountered an unexpected error. Please try again later.

Error: Call to undefined method Drupal\Core\Extension\ModuleHandler::getImplementations() in xmlsitemap_check_status() (line 2351 of modules/contrib/xmlsitemap/xmlsitemap.module).

Proposed resolution

Remove deprecated code.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#15 Screenshot 2023-07-18 at 14.32.27.png293.88 KBmikee
#11 3323148.patch2.23 KBarnaud-brugnon

Issue fork xmlsitemap-3323148

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

abhaisasidharan created an issue. See original summary.

abhaisasidharan opened merge request !23

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 8.x-1.4 » 8.x-1.x-dev
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

arnaud-brugnon’s picture

arnaud-brugnon commented
StatusFileSize
new 3323148.patch2.23 KB

If someone needs the patch to solve issue without going to dev branch, here's one

pobster’s picture

pobster commented

Just an FYI, there's no need to generate patches - you can just generate one from the VCS, by sticking .patch to the end of the commit hash.

https://git.drupalcode.org/project/xmlsitemap/-/commit/f7122db.patch

lindsay.wils’s picture

lindsay.wils commented

Just checking on the status of getting this fixed committed and released?

Thanks in advance.

ressa’s picture

ressa
he/him
commented

Thanks for fixing this! The patch solves the problem, and the error is gone.

But this still happens, if you install the latest release ... So perhaps a fresh version could be released, which includes this patch?

mikee’s picture

mikee commented
StatusFileSize
new Screenshot 2023-07-18 at 14.32.27.png293.88 KB

I also needed to install the patch: 3323148.patch for XML sitemap 8.x-1.4 to work on Drupal 10.

Without the patch the config page /admin/config/search/xmlsitemap gave an error.

Many thanks.

millnut’s picture

millnut commented

Patched worked for me also, any chance of getting a new release tagged?

ressa’s picture

ressa
he/him
commented

1.5 was just released, and the error is gone: https://www.drupal.org/project/xmlsitemap/releases/8.x-1.5. Thanks @Dave Reid!