Fix failing tests [#3323074]

Problem/Motivation

The tests are failing since D10 update: https://www.drupal.org/pift-ci-job/2519141

Steps to reproduce

Proposed resolution

The automated D10 issue is fixed and merged, therefore we cannot use that branch as it is not being updated: https://www.drupal.org/project/page_manager/issues/3297800, however the latest commit on the latest pull request should cover the fix for the tests.

Remaining tasks

Fix tests.

User interface changes

API changes

Data model changes

Issue fork page_manager-3323074

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3323074-fix-failing-tests changes, plain diff MR !11
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

22 November 2022 at 10:45

balintpekker created an issue. See original summary.

Comment #2

22 November 2022 at 11:15

balintpekker opened merge request !11

Comment #3

mglaman

English

WI, USA

commented 7 December 2022 at 16:05

Status:

Active

» Needs work

Comment #4

mglaman

English

WI, USA

commented 7 December 2022 at 16:16

Didn't review test fails, could they be due to CSS though? starterkit has class names like Classy which Stark does not.

Comment #5

balintpekker

he/him

Hungarian

Budapest, Hungary

commented 12 December 2022 at 13:36

So, 9.5.x is the latest version to have the 9.3.0 fixtures, and D10 only has the 9.4.0 starting from beta1.

https://git.drupalcode.org/project/drupal/-/tree/9.4.x/core/modules/syst...
https://git.drupalcode.org/project/drupal/-/tree/9.5.x/core/modules/syst...
https://git.drupalcode.org/project/drupal/-/tree/10.0.x/core/modules/sys...

For some reason, using the core provided filled version instead of the bare breaks the D9.4.7 version, however using the bare will provide us with a missing 'Continue' element. We might need to create our own fixture for this one (?).