Problem/Motivation

This is a followup to #3227824: Move the linkset functionality from the decoupled menus contributed module to core's system module. In #157 over there alexpott commented:

When this lands we should create a followup to use ApiRequestTrait in \Drupal\Tests\rest\Functional\ResourceTestBase.

Steps to reproduce

N/A

Proposed resolution

Remaining tasks

Patch
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3322640-nr-bot_3780ax_j.txt90 bytesneeds-review-queue-bot
#3 use_apirequesttrait-3322640-3.patch1.98 KBvbouchet

Issue fork drupal-3322640

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Active » Needs review
StatusFileSize
new use_apirequesttrait-3322640-3.patch1.98 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Think it's a CC failure? Though updated deps is new to me.

Maybe turn to an MR to be sure?

Change looks fine though. Just optimizing existing code.

vbouchet’s picture

vbouchet
Location Toulouse
commented

As you mentioned in other issue, seems the tests are not executed automatically anymore. At least I had to manually queues these for the few patches I submited today and I also noticed the "deps" things. I will try to turn it into a MR layer.

vbouchet opened merge request !5317

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Needs work » Needs review

I applied the same change in a MR instead of a patch.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reran nightwatch and it was a random failure.

Change looks good!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

I think this should also try to replace ResourceTestBase::request() with ApiRequestTrait::makeApiRequest() as the code looks pretty similar.

We might need a wrapper or we might be able to say

use ApiRequestTrait {
  makeApiRequest as request;
}

and just delete the request method.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

sivaji_ganesh_jojodae made their first commit to this issue’s fork.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs work » Needs review

I did the rebase, and I do not see any commits or changes afterward. Has this issue already been resolved?

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3322640-nr-bot_3780ax_j.txt90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.