Issue fork saml_sp-3320630

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Naveen Kumar Reddy created an issue. See original summary.

Naveen Kumar Reddy opened merge request !28

Naveen Kumar Reddy’s picture

Naveen Kumar Reddy commented
Issue summary: View changes
Status: Active » Needs review

Hi
As per #2 we changed README.txt with README.md please review it.

thank you

karanpagare’s picture

karanpagare commented
Status: Needs review » Needs work

Needs some work , missing info about tags and information such as Introduction , Maintainers and Features

Manoj Raj.R made their first commit to this issue’s fork.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review

Added Introduction, Maintainers.

Please provide features so it can be added.

Please review.

jrglasgow made their first commit to this issue’s fork.

nupur badola’s picture

nupur badola commented

Issue is still there in the patch.

git.drupalcode.org_project_saml_sp_-_merge_requests_28.diff.txt:51: trailing whitespace.
```
warning: 1 line adds whitespace errors.
jproctor’s picture

jproctor
they/them
Primary language English
commented
Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Fixed

Thank you; I have removed the whitespace from the file in 4.x-dev; the fix will be included in the next release.

Also this issue never got closed so I’m doing that now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.