Closed (fixed)
Project:
Bookmarks
Version:
1.0.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Nov 2022 at 21:34 UTC
Updated:
2 Aug 2024 at 18:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rdworianyn commentedPlease disregard, this was a conflict with another module. I swore I was testing on a fresh install, but I stand corrected.
Comment #3
rdworianyn commentedComment #4
cestmoi commentedI just installed and testing the module and got this issue too.
I'm having this same issue and I have no such conflict with another Flag module.
Only admin can access the block (no roles restricted).
Flag Bookmark and Unflag Bookmark permissions are given to authenticated users.
Same even if I give users permission to See Other's Bookmarks just to test.
Comment #5
asherry commentedWe're having the same issue. This block is doing its access check based on
\Drupal\flag\Entity\Flag::access(). I don't know if/when things changed, but, the flag module doesn't actually seem to use the ::access() method for flagging, it seems to just use that for administration.Access to see if a user has the permission to do a flag action is done with the "access_check" tagged services FlagAccessCheck and UnFlagAccessCheck. It makes sense I guess, the actual places it needs to check access are primarily done in routes. These methods are calling the
Flag::actionAccessmethod and rather than use "create" as an action, it uses "flag" and "unflag".I added a patch to check which action needs to be sent to ::actionAccess and then returned that for ::blockAcces.
Comment #6
asherry commentedFixed two major issues with the last patch.
Comment #7
jcandan commentedPatch #6 fixed the issue for us on Drupal 10.3.0 with Bookmarks 1.0.2.
Comment #8
jcandan commentedSeems I missed a bug. After applying the patch, the links and title fields don't show in the Bookmarks list table. Digging.
Comment #9
jcandan commentedComment #11
jcandan commentedComment #13
jcandan commentedComment #14
asherry commentedDid you actually use the patch I had? I don't see a credit associated with this issue, or maybe it was because I got a warning that says "Double check attribution"
Comment #15
jcandan commentedComment #16
jcandan commentedComment #18
problue solutionsDev version dated 12 July 2024 fixes the access problem, but the issue descibed in #8 (links not appearing in bookmark list table) is not fixed.
Comment #19
jcandan commentedApologies, I should have noted this here before. The bug described in #8 and #18 should be resolved by #3366545: Fix Bookmarks view is missing a display.