Problem/Motivation
Replace README.txt with README.md

Steps to reproduce
Need to change README.md formate

Proposed resolution
Follow this pattern
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

CommentFileSizeAuthor
#13 Entities_import.png116.65 KBnupur badola
#2 3320056-#2.patch2.51 KBgowthami reddy

Issue fork entities_import-3320056

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gowthami reddy created an issue. See original summary.

gowthami reddy’s picture

gowthami reddy commented
Status: Active » Needs review
StatusFileSize
new 3320056-#2.patch2.51 KB

Change the file readme.txt to readme.md
please review it

Manoj Raj.R made their first commit to this issue’s fork.

Manoj Raj.R opened merge request !1

Sonal Gyanani made their first commit to this issue’s fork.

Sonal Gyanani’s picture

Sonal Gyanani commented
Assigned: gowthami reddy » Unassigned

Fixed formatting issues.
Please review

nupur badola’s picture

nupur badola commented

Patch is working however issue is still there.

1.diff.txt:9: trailing whitespace.
It provides user interface to import Entity(Content and Taxonomy) from excel
1.diff.txt:14: trailing whitespace.

1.diff.txt:19: trailing whitespace.
- file/image
1.diff.txt:20: trailing whitespace.
- paragraph
1.diff.txt:44: trailing whitespace.
Install the Entities Import module as you would normally install a
warning: squelched 13 whitespace errors
warning: 18 lines add whitespace errors.
Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Needs work

I will work on it.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs work » Needs review

Updated the changes.

Please review it.

paraderojether made their first commit to this issue’s fork.

paraderojether’s picture

paraderojether commented

I reviewed the MR!1 and there is still and an issue when applying the MR shown below: 

1.diff.patch:14: trailing whitespace.

warning: 1 line adds whitespace errors.
paraderojether’s picture

paraderojether commented

I updated the MR to fix the issue.

Please review.
Thank You.

nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Entities_import.png116.65 KB

Patch is working and marking it to RTBC.

elavarasan r’s picture

elavarasan r commented
Status: Reviewed & tested by the community » Fixed
elavarasan r’s picture

elavarasan r commented
Status: Fixed » Closed (fixed)
elavarasan r’s picture

elavarasan r commented
Version: 8.x-1.x-dev » 2.0.0