We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

CommentFileSizeAuthor
#22 file_entity.png177.55 KBnupur badola
#13 fileentity-3319902-13.patch2.47 KBhithiksahu
#10 fileentity-3319902-10.patch4.36 KBhithiksahu
#5 fileentity-3319902-5.patch4.36 KBhithiksahu
#2 3319902-3.patch101 bytesNila Hyalij

Issue fork file_entity-3319902

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Nila Hyalij created an issue. See original summary.

Nila Hyalij’s picture

Nila Hyalij commented
StatusFileSize
new 3319902-3.patch101 bytes
Nila Hyalij’s picture

Nila Hyalij commented
Status: Active » Needs review

I have added patch.
Please review it.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Needs work

#2 patch failed to apply.
please check your patch file and update

hithiksahu’s picture

hithiksahu commented
Status: Needs work » Needs review
StatusFileSize
new fileentity-3319902-5.patch4.36 KB
Manoj Raj.R’s picture

Manoj Raj.R commented
Assigned: Nila Hyalij » Unassigned
anwar_max’s picture

anwar_max
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

RTBC

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Reviewed & tested by the community » Needs work

hi HithikSahu
You have used 7x version to update the patch.
The version the issue created is for 8x
Please feel free to use the Merge request. You can push it directly. That's the beauty of the Gitlab.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

lol yes that's the 7.x readme, does not apply to 8x

hithiksahu’s picture

hithiksahu commented
Status: Needs work » Needs review
StatusFileSize
new fileentity-3319902-10.patch4.36 KB

dharmeshbarot made their first commit to this issue’s fork.

dharmeshbarot’s picture

dharmeshbarot commented

Created MR!
please review it

hithiksahu’s picture

hithiksahu commented
StatusFileSize
new fileentity-3319902-13.patch2.47 KB
Manoj Raj.R’s picture

Manoj Raj.R commented
Assigned: Unassigned » Manoj Raj.R
Status: Needs review » Needs work

This needs some work to be done.

Manoj Raj.R opened merge request !3

dharmeshbarot’s picture

dharmeshbarot commented

Like now what do we need to implement?

Manoj Raj.R’s picture

Manoj Raj.R commented
Assigned: Manoj Raj.R » Unassigned
Status: Needs work » Needs review

Hi dharmeshbarot
you havenot Opened Merge request which I have done.

I have added and done some minor fixes in the readme file according to the latest Readme File format.
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or...

Please review.

dharmeshbarot’s picture

dharmeshbarot commented

Thanks, @Manoj Raj.R

dharmeshbarot’s picture

dharmeshbarot commented

I made your changes in this branch also 3319902-replace-readme.txt-with

dharmeshbarot opened merge request !4

HithikSahu opened merge request !5

nupur badola’s picture

nupur badola commented
StatusFileSize
new file_entity.png177.55 KB

Readme file doesn't exists. Please refer the snapshot.

Manoj Raj.R’s picture

Manoj Raj.R commented

Hi @Nupur Badola

Its not merged yet.
Please check the link that has been created for MR!3
https://git.drupalcode.org/project/file_entity/-/merge_requests/3

joseph.olstad closed merge request !4

joseph.olstad closed merge request !5

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.