Problem/Motivation

If add the defer tag to all script tags is set to all, the defer tag is not added.

Steps to reproduce

In the admin/config/development/performance/advagg/mod under JS > Adjust javascript location and execution, enable the all (might break things) radio. Inspect your bundled JS and notice the defer tag is missing.

Proposed resolution

It seems the DeferJs.php file is getting the wrong setting.
Instead of js_defer, it's getting css_defer_js_code, which is the CSS setting under Adjust CSS location and execution (Experimental). I think those two settings should not relay on one another and it seems it was just overlooked.

Remaining tasks

- write patch
- test/review

CommentFileSizeAuthor
#4 3319469-advagg-defer-tags-3.patch763 bytesGasparM
#2 3319469-advagg-defer-tags-2.patch717 bytesdeaom

Comments

DeaOm created an issue. See original summary.

deaom’s picture

deaom commented
Status: Active » Needs review
StatusFileSize
new 3319469-advagg-defer-tags-2.patch717 bytes
antares89’s picture

antares89 commented

Hello, can confirm the problem and the patch works fine under version 5.0.

GasparM’s picture

GasparM commented
StatusFileSize
new 3319469-advagg-defer-tags-3.patch763 bytes

Modify the patch to work with 6.0 for Drupal 10