I have just installed 5.x - 1.11 I now get the following warning on my Edit Forum pages:

You have set the Content Access module to control access to content of type Forum topic—this can interfere with proper operation of Forum Access! Specifically, any grants given by Content Access cannot be taken back by Forum Access.

Unless you really know what you're doing, we recommend that you go to the Content Access configuration for the Forum topic type page and clear all checkboxes.

The warning is helpful because it explains the relationship between the Edit Forum pages and the Content Type - Forum Post page which I had not previously understood.

The reason I am getting the warning is because I have got a tick in Edit | author on the Content Type page. I have done this because it does not exist as an option in Forum Access. Please could you add this? It would be very helpful.

Comments

davidteall’s picture

davidteall commented
Title: Lack of User option in Forum Access tick boxes » Lack of Author option in Forum Access tick boxes

Title changed

salvis’s picture

salvis
he/his
commented

What does "Edit | author on the Content Type page" do?

davidteall’s picture

davidteall commented

It allows the author of the post to edit his/her posts irrespective of which role(s) s/he has. At the moment you can only give edit privileges to a role. I know you can set this option on the main Permissions page but that splits the permissions between two places which is never a good idea.

hgmichna’s picture

hgmichna commented

I always found the access rights overdone even in Drupal itself. I think authors should always have the right to edit or delete their own postings. Are you sure that they don't have that in your installation?

If they don't, then I would agree that such a checkbox would be the nearest workaround.

davidteall’s picture

davidteall commented

They do not have the automatic right to be able to edit their own posts which, I agree, seems very silly. They can be given the right on the main Permissions page but as I said above, that means the rights are spread over two quite different pages which can lead to silly errors that can take ages to track down.

The Content Access module, which I suspect most people using Forum Access use to control access to their other content, has a box for 'author' on its lists. I think it would be most helpful to have the same system on Forum Access.

salvis’s picture

salvis
he/his
commented

I understand your reasoning, but others might say that duplicating the same controls on multiple pages is confusing, and it would be difficult to argue against that...

davidteall’s picture

davidteall commented

The ideal is to have all the controls in one place and for that place to be in your module so that all the controls are on a per forum basis rather than global.

salvis’s picture

salvis
he/his
commented

FA can't take permissions away from core. If I understand you correctly, you want to give all edit own <node type> permissions. This is core functionality. Duplicating it on the FA pages would raise even more questions.

BTW, assigning an issue to yourself means you commit to actually work on implementing it — is that your intention?

davidteall’s picture

davidteall commented

What I am asking for is what is already implemented in the Content Access module. Like may users, I suspect, I use Content Access and Forum Access as a pair to control access to my site. Having such a fundamental difference between the two is asking for confusion. Have a look at the Content Access control page and you will see what I am after.

I wish I could offer to work on implementing it but I regret I cannot speak PHP! I thought assigning the issue just menat putting my name to it rather than being anonymous - I've been doing it for years! Sorry about that.

salvis’s picture

salvis
he/his
commented
Version: 5.x-1.11 » 6.x-1.x-dev
Assigned: davidteall » Unassigned
Status: Active » Fixed

I've added a list of the relevant permissions as well as CA-specific analysis and references in the latest 6.x-1.x-dev snapshot. I think this provides a pretty good overview of the forces at work (without duplicating controls). Have a look and let me know what you think...

davidteall’s picture

davidteall commented

It does make things clear, but it still does not allow me to give 'Edit own content' or 'delete own content' permissions. The only way to give these permissions to a Forum is to set them elswehere, either in CA or on the main permissions page, which means spreading the permissions between two places.

salvis’s picture

salvis
he/his
commented

Yes, right.

I don't think global permissions should be settable from under admin/content/forum/edit/forum/TID. I don't see them under admin/content/node-type/forum/access either.

We have to agree to disagree there.

davidteall’s picture

davidteall commented

The two places where you can set 'edit own content' and 'delete own content' are:

admin/content/node-type/forum/access (I'm looking at it right now. There are six sets of tick boxes) and

The main permissions table at: admin/user/permissions | forum module | delete own forum topics and edit own forum topics

The main permissions table also has entries for 'create forum topic' 'delete any forum topic' and 'edit any forum topic'. These three are just as global as 'edit or delete own forum topic' yet you have replicated these three within Forum Access. That is what your module does: it replaces the global permissions with per forum permissions. You have included three of the five global controls and missed out the other two. I just don't understand what it is that you have got against including them.

salvis’s picture

salvis
he/his
commented
Title: Lack of Author option in Forum Access tick boxes » No "edit/delete OWN forum topics" permissions
Status: Fixed » Closed (won't fix)

Ah, I thought you wanted to have access to the global permissions from the admin/content/forum/edit/forum/TID page. I'm finally beginning to understand that you're asking for per-role edit/delete OWN forum topic permissions.

Support for controlling the View, Update, and Delete node access permissions based on various factors is built into Drupal core. The mechanism is completely different from the global permissions. Node access modules generally only leverage that built-in support, which is somewhat efficient, because it's in core. I don't know how CA implements the "own" permissions. Obviously, it's possible, but I don't know how efficient it is.

I don't see overwhelming demand for this feature and only marginal benefits. In fact, introducing additional permissions would increase the complexity of FA, result in even more confused issue reports, and make trouble-shooting more difficult. IOW, I'd be shooting myself in my OWN foot... So, in conclusion, I'm not fundamentally opposed to implementing edit/delete OWN permissions in FA, but there's more going against than in favor of doing this (even if someone else would do the work).

davidteall’s picture

davidteall commented

That's a shame, but at least I have now managed to get over what I was asking for. Thanks for giving it thought.