All method arguments with default values should be declared after the method arguments without default values. Otherwise, it makes it impossible for callers to take advantage of defaults; they must re-specify the defaulted values in order to "get to" the non-default arguments.
File: search_api/tests/src/Unit/Processor/EntityStatusTest.php
83: public function testSupportsIndex(array $datasource_ids = NULL, $expected) {
83: public function testSupportsIndex($expected, array $datasource_ids = NULL) {
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3319384-5--test_classes_code_style.patch | 3.73 KB | drunken monkey |
Comments
Comment #2
Pracheth commentedHi fnalb2,
Updated the class file as per the proposed resolution.
Please review the same.
Comment #4
fnalb2 commentedReviewed
Comment #5
drunken monkeyThanks for reporting this problem and providing a patch, respectively!
However, obviously, when changing the method signature you will also need to adapt the callers accordingly. The test failures should have been a hint.
Furthermore, you see that the
= NULLdefault was just there to allowNULLto be passed (which was necessary before the?arraysyntax for type hinting became available), not as an actual default.Attached is the correct solution to this problem, along with a few other code style fixes in these two files.
Comment #7
drunken monkeyCommitted.