Problem/Motivation
The automated Drupal 10 compatibility patch from the bot seemed too loose.
We need to rework some things here to get a 2.1.0 release for Drupal 10 (and still supporting Drupal 9) and think of the future (3.0.0 release #3102317: [META] Roadmap).
As core will switch to CKEditor5, and we heavily depend on entity_embed, you cannot update to Drupal 10 version before they're ready too.
We will further support CKEditor 4, as we do not have a direct dependency to it, beside the SVG icon (which is already supported in CKEditor 4)
There is not much missing, see: #3272732: Drupal 10 & CKEditor 5 readiness
Remaining tasks
Verify that this still runs on Drupal 9.3 to have the file_url_generator (I also choose to use Drupal.JS once - which depends on Drupal 9.2). Also run on PHP 7.3Decide the minimal version numbers of the required modules (embed, entity_embed)Implement an upgrad path for the icon (PNG 2 SVG)
And hey - it's running
You can setup your Drupal 10 composer.json to use the two modules repos like this:
"repositories": [
{
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/media_directories",
"drupal/entity_embed"
]
},
{
"type": "git",
"url": "git@git.drupal.org:issue/media_directories-3319214.git"
},
{
"type": "git",
"url": "git@git.drupal.org:issue/entity_embed-3272732.git"
}
],
and with Drupal 10 beta2 you'll need these patches:
"patches": {
"drupal/core": {
"#3313473 CKE5 derivable": "https://www.drupal.org/files/issues/2022-10-31/3313473-43.patch"
},
"drupal/entity_embed": {
"#3287235-28: D10": "https://www.drupal.org/files/issues/2022-10-25/3287235-28.patch"
},
"drupal/embed": {
"#3309747 CKE5": "https://git.drupalcode.org/project/embed/-/merge_requests/2.diff"
}
},and then the composer require commands look like this:
composer require drupal/entity_embed:dev-3272732-drupal-10-
composer require drupal/media_directories:dev-3319214-drupal-10
Issue fork media_directories-3319214
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
ytsurkIssue forks seem to need it's time ATM #3319123: "Issue fork creation failed!" after clicking "Create issue fork"
Comment #3
ytsurkComment #4
ytsurkComment #5
ytsurkComment #6
ytsurkComment #7
ytsurkComment #8
ytsurkComment #9
ytsurkComment #10
ytsurkComment #11
ytsurkComment #12
ytsurkComment #13
ytsurkComment #15
ytsurkComment #16
ytsurkComment #17
ytsurkComment #18
ytsurkComment #19
ytsurkComment #20
ytsurkComment #22
ytsurkWe be released with 2.1.0 in the next week(s)
Comment #25
redeight commentedAny word on tagging a release as 10 supported so we can install with composer?
Comment #26
rang501 commentedRelease 2.1 should come in any day, for testing, you could check dev release and give feedback.
Comment #27
podarokThere is an issue with Drupal.org suggested composer constraint and current module repo branches
when you use https://www.drupal.org/project/media_directories/releases/2.1.x-dev
drupal/media_directories:2.1.x-dev@devIt installs branch ```dev-2.x e8a037d``` but should install ```dev-2.1.x be2e8ce```
In order to get 2.1.x branch - use
composer require drupal/media_directories:dev-2.1.xComment #28
redeight commentedI tried installing installing this on a d10 site but ran into some issues. I think it might be because the composer.json file specifies
"drupal/core": ">=9.3"when it should probably have a similar wildcard to the info.yml file. I even tried the specific version as stated in the last comment. Thoughts on how to get this installed on a d10 site?Comment #29
ytsurkWhat version did you try to install?
D10 is still only supported via the -dev version. So use the composer command from here:https://www.drupal.org/project/media_directories/releases/2.1.x-dev
This is more or less an RC. I just created a -beta release
https://www.drupal.org/project/media_directories/releases/2.1.0-beta1
The 2.1.x branch still supports Drupal 9.3.
Comment #30
ytsurkUse -beta1 https://www.drupal.org/project/media_directories/releases/2.1.0-beta1