Problem/Motivation

The automated Drupal 10 compatibility patch from the bot seemed too loose.
We need to rework some things here to get a 2.1.0 release for Drupal 10 (and still supporting Drupal 9) and think of the future (3.0.0 release #3102317: [META] Roadmap).

As core will switch to CKEditor5, and we heavily depend on entity_embed, you cannot update to Drupal 10 version before they're ready too.
We will further support CKEditor 4, as we do not have a direct dependency to it, beside the SVG icon (which is already supported in CKEditor 4)
There is not much missing, see: #3272732: Drupal 10 & CKEditor 5 readiness

Remaining tasks

  • Verify that this still runs on Drupal 9.3 to have the file_url_generator (I also choose to use Drupal.JS once - which depends on Drupal 9.2). Also run on PHP 7.3
  • Decide the minimal version numbers of the required modules (embed, entity_embed)
  • Implement an upgrad path for the icon (PNG 2 SVG)

And hey - it's running

You can setup your Drupal 10 composer.json to use the two modules repos like this:

"repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/media_directories",
                "drupal/entity_embed"
            ]
        },
        {
            "type": "git",
            "url": "git@git.drupal.org:issue/media_directories-3319214.git"
        },
        {
            "type": "git",
            "url": "git@git.drupal.org:issue/entity_embed-3272732.git"
        }
    ],

and with Drupal 10 beta2 you'll need these patches:

        "patches": {
            "drupal/core": {
                "#3313473 CKE5 derivable": "https://www.drupal.org/files/issues/2022-10-31/3313473-43.patch"
            },
            "drupal/entity_embed": {
              "#3287235-28: D10": "https://www.drupal.org/files/issues/2022-10-25/3287235-28.patch"
            },
            "drupal/embed": {
                "#3309747 CKE5": "https://git.drupalcode.org/project/embed/-/merge_requests/2.diff"
            }
        },

and then the composer require commands look like this:

composer require drupal/entity_embed:dev-3272732-drupal-10-
composer require drupal/media_directories:dev-3319214-drupal-10

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk’s picture

ytsurk’s picture

Title: Make module Drupal 10 compatible » Drupal 10 readiness
Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Status: Active » Needs work
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes

ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Issue summary: View changes
ytsurk’s picture

Assigned: ytsurk » Unassigned
Status: Needs work » Needs review

  • ytsurk committed 9032b286 on 2.1.x
    Issue #3319214: Drupal 10 readiness
    
ytsurk’s picture

Status: Needs review » Fixed

We be released with 2.1.0 in the next week(s)

  • ytsurk committed 3230791d on 2.1.x
    Issue #3319214 by ytsurk: Support seven theme (legacy D9)
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

redeight’s picture

Any word on tagging a release as 10 supported so we can install with composer?

rang501’s picture

Release 2.1 should come in any day, for testing, you could check dev release and give feedback.

podarok’s picture

There is an issue with Drupal.org suggested composer constraint and current module repo branches
when you use https://www.drupal.org/project/media_directories/releases/2.1.x-dev

drupal/media_directories:2.1.x-dev@dev
It installs branch ```dev-2.x e8a037d``` but should install ```dev-2.1.x be2e8ce```
In order to get 2.1.x branch - use

composer require drupal/media_directories:dev-2.1.x

redeight’s picture

I tried installing installing this on a d10 site but ran into some issues. I think it might be because the composer.json file specifies "drupal/core": ">=9.3" when it should probably have a similar wildcard to the info.yml file. I even tried the specific version as stated in the last comment. Thoughts on how to get this installed on a d10 site?

ytsurk’s picture

What version did you try to install?

D10 is still only supported via the -dev version. So use the composer command from here:
https://www.drupal.org/project/media_directories/releases/2.1.x-dev

This is more or less an RC. I just created a -beta release
https://www.drupal.org/project/media_directories/releases/2.1.0-beta1

The 2.1.x branch still supports Drupal 9.3.

ytsurk’s picture