Closed (fixed)
Project:
Scheduler
Version:
7.x-1.x-dev
Component:
Coding Standards
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Nov 2022 at 17:30 UTC
Updated:
19 Nov 2022 at 13:19 UTC
Jump to comment: Most recent
Comments
Comment #2
jonathan1055 commentedThe null coalesing operator
??should not be used here, as we have automated testing at PHP5.6 and the ?? operator was only introduced in PHP7. There is no benefit in forcing up the minimum PHP version.Comment #4
jonathan1055 commentedComment #5
erikaagp commentedI'll review it
Comment #6
jonathan1055 commentedI only set to 'needs review' to get the automated tests running.
I have pushed a new commit, because short array syntax is not available at PHP5.6.
However the push has not yet appeared on https://git.drupalcode.org/project/scheduler/-/merge_requests/76
Comment #7
jonathan1055 commentedA bulk update has clogged up the MR and issue queue. It will appear in time.
https://app.slack.com/client/T06GX3JTS/CGKLP028K/thread/CGKLP028K-166755...
Comment #9
jonathan1055 commentedMerged and fixed.
Comment #10
jonathan1055 commented