Due to the newer versions of coder (8.3.16) and codesniffer (3.7.1) we have four coding standards messages to fix for 7.x-1.x

FILE: scheduler/scheduler.edit.inc
-------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------
 46 | ERROR | [x] Use null coalesce operator instead of ternary operator.
    |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
 47 | ERROR | [x] Use null coalesce operator instead of ternary operator.
    |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: scheduler/tests/scheduler.test
-------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------
  575 | ERROR | [x] list(...) is forbidden, use [...] instead.
      |       |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
 1592 | ERROR | [x] list(...) is forbidden, use [...] instead.
      |       |     (SlevomatCodingStandard.PHP.ShortList.LongListUsed)
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

Issue fork scheduler-3318972

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

Issue summary: View changes

The null coalesing operator ?? should not be used here, as we have automated testing at PHP5.6 and the ?? operator was only introduced in PHP7. There is no benefit in forcing up the minimum PHP version.

jonathan1055’s picture

Status: Active » Needs review
erikaagp’s picture

Assigned: Unassigned » erikaagp

I'll review it

jonathan1055’s picture

I only set to 'needs review' to get the automated tests running.
I have pushed a new commit, because short array syntax is not available at PHP5.6.
However the push has not yet appeared on https://git.drupalcode.org/project/scheduler/-/merge_requests/76

jonathan1055’s picture

A bulk update has clogged up the MR and issue queue. It will appear in time.
https://app.slack.com/client/T06GX3JTS/CGKLP028K/thread/CGKLP028K-166755...

  • jonathan1055 committed b79d24a on 7.x-1.x
    Issue #3318972 by jonathan1055: Ignore SlevomatCodingStandard sniffs on...
jonathan1055’s picture

Title: Coding standards with coder 8.3.16 and codesniffer 3.7.1 » Ignore SlevomatCodingStandard sniffs from codesniffer 3.7.1+
Assigned: erikaagp » Unassigned
Status: Needs review » Fixed

Merged and fixed.

jonathan1055’s picture

Title: Ignore SlevomatCodingStandard sniffs from codesniffer 3.7.1+ » [7.x] Ignore SlevomatCodingStandard sniffs in codesniffer 3.7.1+

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.