Problem/Motivation

CKEditor 5 35.3.0 is out: https://github.com/ckeditor/ckeditor5/releases/tag/v35.3.0

Steps to reproduce

Proposed resolution

  1. Update core/package.json
  2. cd core
  3. yarn install
  4. yarn build
  5. yarn build:ckeditor5-types

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

The version of CKEditor 5 has been updated from 35.2.1 to 35.3.0.

CommentFileSizeAuthor
#9 3318867-9-10.x.patch1.96 MBlongwave
#9 3318867-9-9.4.x.patch1.96 MBlongwave
#7 interdiff.txt1.29 KBlauriii
#7 3318867-7-95x.patch1.96 MBlauriii
#2 3318867-2-10.x.patch1.96 MBlongwave
#2 3318867-2-9.5.x.patch1.96 MBlongwave
#2 3318867-2-9.4.x.patch1.96 MBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3318867-2-9.4.x.patch1.96 MB
new 3318867-2-9.5.x.patch1.96 MB
new 3318867-2-10.x.patch1.96 MB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This seems likely to be the version that we ship with 9.5.0 and 10.0.0, given that the next CKEditor 5 iteration is released on December 13, and we plan to release on December 14; that probably doesn't leave us enough time.

The last submitted patch, 2: 3318867-2-9.4.x.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 2: 3318867-2-10.x.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Issue tags: +JavaScript, +9.5.0 release notes, +10.0.0 release notes, +9.4.10 release notes
Parent issue: » #3313946: Update CKEditor 5 to 35.2.1

https://github.com/ckeditor/ckeditor5/releases/tag/v35.3.0 has various mentions of "table caption" — and it looks like they either broke this or we need to tweak our test.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new 3318867-7-95x.patch1.96 MB
new interdiff.txt1.29 KB

I don't think this was an actual regression. It seems like a problem with how the \Drupal\Tests\ckeditor5\FunctionalJavascript\TableTest::testTableCaptionUi tried to modify content within CKEditor 5.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Perfect, that's what I thought/hoped! 😊

Now we just need the same fix to be applied to the 9.4 and 10.0/10.1 patches and we're good to go! 👍

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 3318867-9-9.4.x.patch1.96 MB
new 3318867-9-10.x.patch1.96 MB

#2 with interdiff from #7 applied.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looking great! 🤩

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed b5208e2855 to 10.1.x and 4f7315fd4b to 10.0.x. Thanks!
Committed fedcff2 and pushed to 9.5.x. Thanks!
Committed c136ca7 and pushed to 9.4.x. Thanks!

  • alexpott committed b5208e2 on 10.1.x 
    Issue #3318867 by longwave, lauriii, Wim Leers: Update CKEditor 5 to 35....

  • alexpott committed 4f7315f on 10.0.x 
    Issue #3318867 by longwave, lauriii, Wim Leers: Update CKEditor 5 to 35....

  • alexpott committed fedcff2 on 9.5.x 
    Issue #3318867 by longwave, lauriii, Wim Leers: Update CKEditor 5 to 35....

  • alexpott committed c136ca7 on 9.4.x 
    Issue #3318867 by longwave, lauriii, Wim Leers: Update CKEditor 5 to 35....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: -9.4.10 release notes +9.4.9 release notes