Update CKEditor 5 to 35.2.1

There were actually five errors in the failure above.

/var/www/html/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestBase.php:91
failed 4 times, and contains:

    $panel->find('xpath', "//button[span[text()='Insert']]")->click();

/var/www/html/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageUrlTest.php:109 failed once and contains the same.

So we need to investigate why/how CKEditor 35.2.0 broke our plugins/tests.

If I check the release notes at https://github.com/ckeditor/ckeditor5/releases/tag/v35.2.0, The image insertion pane is no longer empty if opened with the arrow down keystroke. seems most likely: https://github.com/ckeditor/ckeditor5/issues/12215. Investigation needed though.

So the selenium driver triggers a blur event on the input when using the setValue method. This blur makes the CKE5 tooltip disapear, and the insert button ends up ineffective => test failures.

When setValue does not trigger the blur event (with some manual hack) things work as expected.

35.2.1 has been released last week

I think the issue comes from this merge request: https://github.com/ckeditor/ckeditor5/pull/12319/ specifically this commit: https://github.com/ckeditor/ckeditor5/pull/12319/commits/633dead6b6d1a2d...

When adding text to an input, selenium will add the text and then trigger a blur() on the input element. It seems that this blur event (used let the browser trigger a "change" event if necessary) makes the dropdown close and our test fail.

If we defer the blur event from the Selenium2Driver method, tests pass.

Yup, all green.

The issue is not a problem or a regression. CKE5 behaves as expected for a non-machine user (aka. a human), it's because of the default behavior of the selenium driver that the problem appeared once CKE5 fixed their accessibility.

Getting around it by setting the value in the JS directly. This wouldn't have been a problem with a nightwatch test doing the same thing for example.

Per my MR comment, see #3316274-24: Stabilize FunctionalJavascript testing AJAX: add ::assertExpectedAjaxRequest(), where a similar change was needed, but entirely in the Drupal sphere (Drupal's AJAX system getting triggered after setting a form value), compared to this being entirely in the CKEditor 5 sphere. Basically: Selenium/Mink are not realistic 😬

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

There's a conflict in yarn.lock for 9.5.x so this will need a 9.5 version.

Opened a follow-up for the Mink subclass.

forgot to update the tests, hang on

LGTM

FYI, the #18 interdiff (which was also committed to the 10.0.x and 10.1.x branches) will be obsolete (i.e. will get reverted) in #3316816: Stabilize FunctionalJavascript testing AJAX: make ::setValue() trigger both "input" and "formUpdated" events 🤓

Ah didn't realise there was already a follow-up open. Committed/pushed to 10.1.x and cherry-picked back to 10.0.x and 9.5.x.

If we want to backport this to 9.4, it'll need a 9.4-specific patch too. I'm assuming we do so leaving open there for that.

Committed/pushed to 9.4.x, thanks!