Problem/Motivation

FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/src/EventSubscriber/ImagemagickEventSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 316 | ERROR | The array declaration extends to column 171 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/src/ImagemagickFormatMapper.php
------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------
  82 | ERROR | [x] list(...) is forbidden, use [...] instead.
 147 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/src/ImagemagickExecManager.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
 168 | ERROR | The array declaration extends to column 156 (the limit is 80). The array content should be split up over multiple lines
 172 | ERROR | The array declaration extends to column 153 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/src/Plugin/ImageToolkit/ImagemagickToolkit.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
 782 | WARNING | [ ] Unused variable $config.
 857 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/src/Plugin/FileMetadata/ImagemagickIdentify.php
----------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
 148 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 154 | ERROR | [x] Use null coalesce operator instead of ternary operator.
 265 | ERROR | [x] list(...) is forbidden, use [...] instead.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/tests/src/Functional/ToolkitImagemagickFileMetadataTest.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
 40 | ERROR   | Missing short description in doc comment
 69 | WARNING | Unused variable $config.
----------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/tests/src/Functional/EventSubscriberTest.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 31 | ERROR | Missing short description in doc comment
-------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/tests/src/Functional/ToolkitImagemagickTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------
  57 | ERROR   | Missing short description in doc comment
 610 | WARNING | Unused variable $default_corners.
----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/imagemagick/tests/src/Functional/ToolkitImagemagickFormTest.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 26 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------------------------------------------------

Time: 778ms; Memory: 18MB
CommentFileSizeAuthor
#5 Screenshot from 2022-11-01 09-56-54.png75.56 KBerikaagp
#2 coding-standards-3318251-2.patch8.66 KBprasaddeole

Issue fork imagemagick-3318251

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

PrasadDeole created an issue. See original summary.

prasaddeole’s picture

prasaddeole commented
StatusFileSize
new coding-standards-3318251-2.patch8.66 KB
prasaddeole’s picture

prasaddeole commented
Assigned: prasaddeole » Unassigned
Status: Active » Needs review
erikaagp’s picture

erikaagp commented
Assigned: Unassigned » erikaagp

I'll review it

erikaagp’s picture

erikaagp commented
StatusFileSize
new Screenshot from 2022-11-01 09-56-54.png75.56 KB

I reviewed it and the only phpcs errors I found where on the README.md, and the .install doc. (Here there is an screenshot). I'm not sure if the maintainers requiere those docs to be changed or not. If not, this issue is ready to be updated as RTBC. I'll keep an eye on the next comments related with this issue.

prasaddeole’s picture

prasaddeole commented
Assigned: erikaagp » Unassigned
Arturo-q’s picture

Arturo-q commented
Status: Needs review » Reviewed & tested by the community

Hi, I reviewed the patch too and regarding what #5 said, I agree, let's move to RTBC, and let's wait for the maintainer's decision.

  • mondrake committed fff2daa on 8.x-3.x 
    Issue #3318251 by erikaagp, PrasadDeole, Arturo1007: Fix phpcs coding...
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.