Problem/Motivation

FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/weight/src/Plugin/Field/FieldWidget/WeightSelectorWidget.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 26 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/weight/src/Plugin/views/field/WeightSelector.php
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 117 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal_cms/drupal9/web/modules/contrib/weight/weight.views.inc
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
 17 | WARNING | Unused variable $table_name.
----------------------------------------------------------------------------------

Time: 122ms; Memory: 12MB
CommentFileSizeAuthor
#8 weight_phpcs.png106.68 KBatul_ghate
#5 fix-phpcs-coding-standards-3318185-5.patch2.09 KBdharti patel
#2 coding-standards-3318185-2.patch1.78 KBprasaddeole

Issue fork weight-3318185

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

PrasadDeole created an issue. See original summary.

prasaddeole’s picture

prasaddeole commented
StatusFileSize
new coding-standards-3318185-2.patch1.78 KB
prasaddeole’s picture

prasaddeole commented
Assigned: prasaddeole » Unassigned
Status: Active » Needs review
dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel
dharti patel’s picture

dharti patel commented
StatusFileSize
new fix-phpcs-coding-standards-3318185-5.patch2.09 KB

Hello,

I reviewed the #2 patch, but after applying this patch, one issue remains.

FILE: /home/drupal/d9-open/weight/weight.module
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 13 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
----------------------------------------------------------------------------------------------------------------------------

Fixed the above issue and create a new patch for the same.
Please review the patch.

Thanks!

prasaddeole’s picture

prasaddeole commented
Assigned: dharti patel » Unassigned
atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

Hi,
I will review this patch.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new weight_phpcs.png106.68 KB

I have reviewed and applied the patch cleanly. It looks good to me, RTBC

renatog’s picture

renatog commented
Issue tags: -Coding standards

I also tested and #5 still being applied into 8.x-3.x and is really working fine without errors on phpcs, so +1 to it

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora opened merge request !11

Neslee Canil Pinto made their first commit to this issue’s fork.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.