Problem/Motivation

Right now the populateOptions, populateData and populateAxes method in the Drupal\charts_highcharts\Plugin\chart\Library\Highcharts are marked as private. This make it harder to implement another Highcharts library like the Highstock or Highmaps without copying all the code even if they are not going to be that different.

Steps to reproduce

Try to implement a one of the library mentioned above.

Proposed resolution

Make populateOptions, populateData and populateAxes protected instead of private.

Remaining tasks

Submit a patch or MR.

User interface changes

N/A

API changes

This means now we need to think about backward compatibility when trying to change something in those methods.

Data model changes

N/A

Issue fork charts-3317896

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nikathone created an issue. See original summary.

nikathone opened merge request !45

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Active » Needs review

Now that the test have pass. Setting this to needs review for manual check.

andileco made their first commit to this issue’s fork.

  • nikathone committed 49b27b8 on 5.0.x 
    Issue #3317896 by nikathone: Make it easier for other module to extend...
andileco’s picture

andileco commented
Status: Needs review » Fixed

Makes sense and looks good!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.