The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Core migration issues
Next video meeting 2023-01-05 2100Z (tentative)
0️⃣ Who is here today?
| mikelutz (he/him) | Hi all. |
| benjifisher | Hello! If we have another quiet meeting this week, then I will work on an issue or two. |
| danflanagan8 | I’m kind of here |
| mradcliffe | Hi, not really participating, but saying Hi. Made it passed the hard (media + commerce) upgrade migration I was working on that had lots of ups/downs mainly downs unfortunately. Hopefully the next one goes better. |
1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
| danflanagan8 | Here’s a thread from #contribute that might be of interest to the migrate team: https://drupal.slack.com/archives/C1BMUQ9U6/p1667413118113439
|
| danflanagan8 | I replied by referencing a couple open migrate issues. |
| benjifisher | How do you keep up with the #contribute channel? That seems like a full-time job. |
| danflanagan8 | I ignore almost all of it. This one jumped out at me. :slightly_smiling_face: |
2️⃣ Action items. To be added later.
3️⃣ Statistics
| benjifisher | Fixed since last week's meeting: 2 (not counting issues for meetings). |
| benjifisher | RTBC: 1, which is Major. |
| benjifisher | NR: 10, all Normal priority, and 1 that has not been updated in more than two months. |
| benjifisher | Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi... |
4️⃣ Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...
5️⃣ Previous minutes.
| benjifisher | We have a backlog of meeting issues that NR:
I think I added the transcripts for all of these, so someone else should review. Anyone can mark them RTBC, and then I will promote them to Fixed. |
| benjifisher | That is 1/3 of the NR queue. I did not include the meeting issues in the counts in 3️⃣. |
6️⃣ SQL source plugins throw exceptions if database is not available
| benjifisher | #3312733: SQL migrations cannot be instantiated if database is not available and Node, Migrate Drupal modules are enabled |
| benjifisher | I classified this as a bug fix. That means that I do not have to worry about BC, right? :wink:
Let me put a patch on it. |
| benjifisher | Actually, @quietone already posted a patch. We need to figure out how to test it. :thinking_face: |
| benjifisher | In SqlBaseTest.php (kernel test) we already test for the connection being undefined. It should not be too hard to test for the connection to be defined but not connectable. |
| benjifisher | You cannot use expectException more than once, right? So either put one expected exception in a try/catch block or add a separate test. |
| benjifisher | I wrote,It should not be too hard to test for the connection to be defined but not connectable. Connectable? available? Something else? FWIW, we opened this issue when I was testing #3063856: Add ability to view migrate_message table data after a D7 -> D9 migration with a DDev project for each site. Then I shut down the D7 site and tried to view the messages. Anyway, I added a test and now the issue is NR. |
| benjifisher | BTW, the reason this issue is important is that it blocks #3063856: Add ability to view migrate_message table data. |
7️⃣ Exception trace cannot be serialized because of closure
| benjifisher | #3197324: Exception trace cannot be serialized because of closure |
| benjifisher | This issue came up in a thread on the #contribute channel. (See 1️⃣ for a link.) |
| danflanagan8 | From that Slack thread:Well, folks shouldn’t be passing translatable markup objects to exception messages. That’s my bug for sure I’m totally outmatched by these issues, but I wonder if that might help make progress on the migrate issues. |
| danflanagan8 | There’s a meta related to this too: #3192893: [META] Serialization issues in Migration tests |
| danflanagan8 | Anyway, I don’t really have more to say on this topic. I just thought that the Slack thread may have some insight from some smart people that wouldn’t typically be working on migrate issues. |
| benjifisher | I am in pretty much the same situation as you. But it seems that people have been commenting on the issue, and even adding a patch for it, after the maintainer closed it. I suggested in the thread on #contribute that opening a new issue might be more effective. |
| damienmckenna | The problem that I ran into was that it wasn't obvious what the cause of the error was, so someone who knows the APIs better might know not to do a certain thing, but someone who doesn't just gets this useless error. |
| damienmckenna | On Metatag I specifically added mpyw/phpunit-patch-serializable-comparison as a dev dependency because of this problem. |
8️⃣ Make Media and Commerce migrations easier
| benjifisher | @mradcliffe: Let's think positively. What can we do to make the next one easier?Maybe start by just listing some of the pain points. |
| mradcliffe | Definitely! |
| mradcliffe | Win: I'm getting better at adding custom migration tags to migrate_plus migration entities so that I can better target incremental migrations. |
| mradcliffe | Win: getting commerce promotions and coupons to mainly work with some caveats (need more reviews / work to help quietone out who is the maintainer of commerce_migrate) |
| mradcliffe | Still troublesome: media_migration half worked (file_entity -> media worked, but image fields did not), but didn't realize it until site building started so I had to revert configuration and redo the migration twice. This led me to better using migration tags to isolate a set of migrations (configuration, but not using "Configuration" since that would get the broken default group migrations to run too). |
| mradcliffe | and run configuration first, take a snapshot |
| benjifisher | We already have this documentation page: https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-6-or-...…]ssues-when-upgrading-from-drupal-6-or-7-to-drupal-9-or-higher. It is a good place to list pain points and links to open issues. |
| mradcliffe | then setup migration tags for "ContentOnce" and "highwater" (again can't use Content because default group migrations run as well :|) |
| benjifisher |
and run configuration first, take a snapshot I routinely start by running the config migrations, fixing problems, and then committing the configuration. Does any of our documentation suggest this approach? I also think that we should provide a way to run Content and Configuration separately in the UI. |
| mradcliffe | I think the drush approach is the recommended approach over the UI and that doesn't suggest running a tag or a group. |
| benjifisher | Is it worth managing migrations with tags? Why not just dump all your migrations into a simple shell script?
I have done that, and someone asked about it on this channel a few days ago. |
| mradcliffe | I've been trying to follow what's on the docs as the best / suggested practice. |
| benjifisher | That should be an iterative process! That is, part of the loop should be updating the docs. |
| mradcliffe | But I've considered shell scripts, but that may not be available / easy-to-use for everyone. |
| danflanagan8 |
part of the loop should be updating the docs. I know there’s an ongoing conversation about revamping the credit system. Maybe docs need to be a bigger part of that convo. |
| mradcliffe | I don't think I ever created or followed up on (creating) an issue regarding being able to generate message/map tables via migrate:status rather than migrate:message |
| mradcliffe | Right now I'm glad that the stress of this latest one is starting to subside (not just migrate sub-system related). |
| (anonymous) | Comment Redacted |
| benjifisher | That is the way that technical debt accumulates. |
| dinarcon | Tangentially related. It would be great to get #3269743: Support Migrate Plus >=4.2 and Drupal 10 in. Not sure what the current scope / todos are. |
| damienmckenna | ^ and the D10 issue definitely need to be committed soon, preferably with a new release. |
9️⃣ Wrap up
| benjifisher | Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting. |
Comments
Comment #6
benjifisherI am adding a transcript.
Comment #7
quietone commentedI compare this to the slack thread and did not find any errors or omissions.