Problem/Motivation

PHPStan baseline reports Result of function usleep (void) is used. in HoldTestSubscriber.

Proposed resolution

Fix HoldTestSubscriber errors, clean up the baseline.

CommentFileSizeAuthor
#6 3317658-6.patch1.38 KBravi.shankar
#4 interdiff_2-4.txt1.38 KBpooja saraah
#4 3317658-4.patch1.46 KBpooja saraah
#2 3317658-2.patch1.41 KBmondrake

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 3317658-2.patch1.41 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: #3291519: Fix remaining method.notFound PHPStan L0 errors »
pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 3317658-4.patch1.46 KB
new interdiff_2-4.txt1.38 KB

Couldn't apply the Patch #2 on Drupal 10.0.x
Fixed failed commands on #2
Attached patch against Drupal 10.0.x

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Patch does not apply.

Is it simpler to just say

while ((bool) file_get_contents($path)) {
  usleep(static::WAIT);
}

?

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3317658-6.patch1.38 KB

Rerolled the patch and made changes as per comment #5.

Status: Needs review » Needs work

The last submitted patch, 6: 3317658-6.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Random fail? Sending it for another try.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

  • catch committed 3af57f4 on 10.0.x 
    Issue #3317658 by pooja saraah, mondrake, ravi.shankar, longwave: Fix...
  • catch committed 08b0f54 on 10.1.x
    Issue #3317658 by pooja saraah, mondrake, ravi.shankar, longwave: Fix...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.