Closed (fixed)
Project:
Drupal core
Version:
10.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Oct 2022 at 19:55 UTC
Updated:
17 Nov 2022 at 08:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mondrakeComment #3
longwaveI am sure in this case this could just be abstract? Updaters are only used by core, there are only Module and Theme implementations, and I don't see a use case outside of that.
Comment #4
mondrakeThanks @longwave, NW
Comment #5
mondrakeComment #6
longwaveThanks, I think this is fine even if it's technically an API change - all this Updater code should be considered internal as far as I can see.
Comment #7
alexpottCommitted d96c99b and pushed to 10.1.x. Thanks!
Committed 104a255 and pushed to 10.0.x. Thanks!
I debated whether we should have a CR for this but I don't think so. The only stuff I can find in contrib is from clones of core... see https://git.drupalcode.org/search?group_id=2&page=3&repository_ref=&scop...
I think we should file a follow-up for the abstract class to implement \Drupal\Core\Updater\UpdaterInterface and then fix the docs in the abstract to use @inheritdoc.
Comment #10
mondrakeFiled #3318850: Make Updater implement UpdaterInterface.